Re: [PATCH 1/1] OMAP3: rx-51: Add full regulator definitions

[Jarkko Nikula <jhnikula@gmail.com>]

On Fri, 29 Apr 2011 15:47:44 +0300
Kalle Jokiniemi <kalle.jokiniemi@nokia.com> wrote:

> +static struct regulator_init_data rx51_vintana1 = {
> +	.constraints = {
> +		.name			= "VINTANA1",
> +		.min_uV			= 1500000,
> +		.max_uV			= 1500000,
> +		.always_on		= true,
...
> +static struct regulator_init_data rx51_vintdig = {
> +	.constraints = {
> +		.name			= "VINTDIG",
> +		.min_uV			= 1500000,
> +		.max_uV			= 1500000,
> +		.always_on		= true,

Are these two used at all? According to public schematics they are
connected to just one capasitor. Could be some needed filtering/charge
pump capacitors for TWL though.

I was thinking are all of these regulators really always_on? How about
letting those without any known user to be switched off?

> @@ -838,6 +911,8 @@ static int __init rx51_i2c_init(void)
>  	omap_register_i2c_bus(2, 100, rx51_peripherals_i2c_board_info_2,
>  			      ARRAY_SIZE(rx51_peripherals_i2c_board_info_2));
>  	omap_register_i2c_bus(3, 400, NULL, 0);
> +	regulator_has_full_constraints();
> +
>  	return 0;
>  }
>  
Move this somewhere else than in i2c initialization function :-)

-- 
Jarkko