linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: "Munegowda, Keshava" <keshava_mgowda-l0cyMroinI0@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	gadiyar-l0cyMroinI0@public.gmane.org,
	p-basak2-l0cyMroinI0@public.gmane.org,
	axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
	mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw@public.gmane.org
Subject: Re: [PATCH] omap:usb: fixing ehci phy gpio values for omap3
Date: Mon, 2 May 2011 14:54:08 +0300	[thread overview]
Message-ID: <20110502115408.GC2529@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <BANLkTi=kH02P9GFo6wmPpRGr=L582DEp0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Mon, May 02, 2011 at 05:01:05PM +0530, Munegowda, Keshava wrote:
> On Mon, May 2, 2011 at 3:08 PM, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote:
> > On Thu, Apr 21, 2011 at 07:52:42PM +0530, Keshava Munegowda wrote:
> >> From: Keshava Munegowda <Keshava_mgowda-l0cyMroinI0@public.gmane.org>
> >>
> >> The gpio of EHCI phy should be 0 instead of 1;
> >> This fixes the hub enumeration issue in beagle xm board.
> >>
> >> Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
> >
> > applied, thanks
> >
> > --
> > balbi
> 
> Thanks balbi
> 
> but ,.his patch is was made by Juergen Kilb ( patch description  and link is
> given below); But I was not aware of it and reinvented wheel with
> beagle-xm board :(
> 
> So, Juergen Kilb is the first author of this patch.
> 
> Here is the link :
> http://www.mail-archive.com/linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg48215.html
> 
>   omap:usbhs:Fixed gpio polarity of gpio USB-phy reset
> 
>     With commit 19403165 a main part of ehci-omap.c moved to
>     drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
>     Due to this reorganisation the polarity used to reset the
>     external USB phy changed and USB host doesn't recognize
>     any devices.
> 
>     Signed-off-by: Juergen Kilb <J.Kilb-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>

I sent a pull request to Greg with that patch in, so it looks like
Samuel also didn't send this patch before. Can you reply to the pull
request I sent saying that this patch should be dropped just so Greg
knows and I recreate the branch and send another pull request ?

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2011-05-02 11:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21 14:22 [PATCH] mfd: Fix usbhs_enable error handling Keshava Munegowda
     [not found] ` <1303395763-8702-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-04-21 14:22   ` [PATCH] omap:usb: fixing ehci phy gpio values for omap3 Keshava Munegowda
     [not found]     ` <1303395763-8702-2-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-04-21 14:22       ` [PATCH] omap:usb: add regulator support for EHCI Keshava Munegowda
     [not found]         ` <1303395763-8702-3-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-05-02  9:38           ` Felipe Balbi
2011-04-26 13:40       ` [PATCH] omap:usb: fixing ehci phy gpio values for omap3 Menon, Nishanth
     [not found]         ` <BANLkTi=fQCRAST1DvJEAnznNnySCv55Yag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-27  5:52           ` Munegowda, Keshava
     [not found]             ` <BANLkTi=apB0cZpgzFjHKuArrxkQX5W7deQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-27  7:58               ` Felipe Balbi
     [not found]                 ` <20110427075843.GS13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-04-27  8:26                   ` Munegowda, Keshava
2011-05-02  9:38     ` Felipe Balbi
     [not found]       ` <20110502093815.GQ2529-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-05-02 11:31         ` Munegowda, Keshava
     [not found]           ` <BANLkTi=kH02P9GFo6wmPpRGr=L582DEp0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-02 11:54             ` Felipe Balbi [this message]
2011-05-02 12:23               ` Munegowda, Keshava
2011-04-26  8:58   ` [PATCH] mfd: Fix usbhs_enable error handling Felipe Balbi
     [not found]     ` <20110426085846.GI13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-04-26  9:02       ` Keshava Munegowda
2011-04-26  9:04         ` Felipe Balbi
     [not found]           ` <20110426090418.GJ13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-04-26 15:09             ` Steve Calfee
     [not found]               ` <BANLkTi=NB5as-Kz8bSCvh3=KPQR1wwXUOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-26 19:34                 ` Felipe Balbi
     [not found]                   ` <20110426193407.GR13227-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-04-26 20:57                     ` Steve Calfee
2011-05-02  9:37   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110502115408.GC2529@legolas.emea.dhcp.ti.com \
    --to=balbi-l0cymroini0@public.gmane.org \
    --cc=axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=gadiyar-l0cyMroinI0@public.gmane.org \
    --cc=johnstul-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=keshava_mgowda-l0cyMroinI0@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mpfj-list-kZtEnBLzDKq1Qrn1Bg8BZw@public.gmane.org \
    --cc=p-basak2-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).