From: Tony Lindgren <tony@atomide.com>
To: green@linuxhacker.ru
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] Initial B&N Nook Color (encore) support.
Date: Tue, 3 May 2011 02:22:38 -0700 [thread overview]
Message-ID: <20110503092237.GM2092@atomide.com> (raw)
In-Reply-To: <1304006259-7939-2-git-send-email-green@linuxhacker.ru>
* green@linuxhacker.ru <green@linuxhacker.ru> [110428 08:55]:
> From: Oleg Drokin <green@linuxhacker.ru>
>
> Bare-bones board file, comes with serial console, gpio keys,
> MMC/SDCard and USB support.
Good to see that. Unfortunately you probably have to do few
more rebases on the devel-cleanup branch because of the code
consolidation effort. We'll have to wait a bit and see what
new platform code we can merge after that is all the
consolidation is sorted out.
Please also post your series with linux-arm-kernel mailing
list Cc'd. Few comments below too.
> +#include <mach/gpio.h>
This should be linux/gpio.h nowadays.
> + if(is_encore_board_evt2()) {
You should have if ( here with space.
Maybe run scripts/checkpatch.pl --strict on the patch?
> --- a/arch/arm/tools/mach-types
> +++ b/arch/arm/tools/mach-types
> @@ -962,7 +962,7 @@ omapl138_case_a3 MACH_OMAPL138_CASE_A3 OMAPL138_CASE_A3 3280
> uemd MACH_UEMD UEMD 3281
> ccwmx51mut MACH_CCWMX51MUT CCWMX51MUT 3282
> rockhopper MACH_ROCKHOPPER ROCKHOPPER 3283
> -nookcolor MACH_NOOKCOLOR NOOKCOLOR 3284
> +encore MACH_ENCORE ENCORE 3284
> hkdkc100 MACH_HKDKC100 HKDKC100 3285
> ts42xx MACH_TS42XX TS42XX 3286
> aebl MACH_AEBL AEBL 3287
For this you need to follow the instructions at www.arm.linux.org.uk.
Regards,
Tony
next prev parent reply other threads:[~2011-05-03 9:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 15:57 Initial B&N Nook Color support, take two green
2011-04-28 15:57 ` [PATCH 1/2] Initial B&N Nook Color (encore) support green
2011-04-28 23:34 ` Abimanyu Gottumukkala
2011-04-29 0:49 ` Oleg Drokin
2011-05-03 11:08 ` Vladimir Pantelic
2011-05-03 9:22 ` Tony Lindgren [this message]
2011-04-28 15:57 ` [PATCH 2/2] Add tps65921 chip green
2011-04-28 17:05 ` Initial B&N Nook Color support, take two Paul Walmsley
2011-04-28 17:21 ` Oleg Drokin
-- strict thread matches above, loose matches on Subject: below --
2011-05-08 21:50 Initial B&N Nook Color support, take three green
2011-05-08 21:50 ` [PATCH 1/2] Initial B&N Nook Color (encore) support green
2011-05-09 7:03 ` Igor Grinberg
2011-05-13 3:52 ` Oleg Drokin
2011-05-15 7:25 ` Igor Grinberg
2011-05-09 20:28 ` Mark Brown
2011-04-27 1:52 Initial B&N Nook Color support green
2011-04-27 1:52 ` [PATCH 1/2] Initial B&N Nook Color (Encore) support green
2011-04-27 8:54 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503092237.GM2092@atomide.com \
--to=tony@atomide.com \
--cc=green@linuxhacker.ru \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).