From: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
To: Sutharsan <sutharsan.tech-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
david.cross-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org,
srmt-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH] Staging: Westbridge: replace custom debug macros with pr_...() macros
Date: Tue, 3 May 2011 10:54:12 -0700 [thread overview]
Message-ID: <20110503175412.GA18990@kroah.com> (raw)
In-Reply-To: <20110428194725.GB25302-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
On Thu, Apr 28, 2011 at 12:47:25PM -0700, Greg KH wrote:
> On Thu, Apr 28, 2011 at 11:48:41AM -0700, Sutharsan wrote:
> > >From Sutharsan Ramamoorthy <srmt-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>
> >
> > This patch replaces custom debug macros with Linux kernel's pr_...() macros.
>
> Why not use the dev_dbg() and other macros instead of these? You do
> have access to a struct device for all of these places in the code,
> right?
As I never got a response from you, I'm dropping this from my
patch-queue. Please resend when you have addressed this issue.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-05-03 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 18:48 [PATCH] Staging: Westbridge: replace custom debug macros with pr_...() macros Sutharsan
2011-04-28 19:40 ` Michal Nazarewicz
2011-04-28 19:47 ` Greg KH
[not found] ` <20110428194725.GB25302-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2011-05-03 17:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503175412.GA18990@kroah.com \
--to=greg-u8xffu+wg4eavxtiumwx3w@public.gmane.org \
--cc=david.cross-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=srmt-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org \
--cc=sutharsan.tech-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox