linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-omap@vger.kernel.org
Subject: OMAP1: unnecessary timer interrupt handler code?
Date: Sun, 8 May 2011 17:28:00 +0100	[thread overview]
Message-ID: <20110508162800.GM27807@n2100.arm.linux.org.uk> (raw)

MPU timer 2 is used on OMAP1 for the clock source and scheduler clock.
It registers an interrupt, which counts the number of overflows of
this timer.  However, this counter is only referenced by the interrupt
handler.

So, it seems that the following code serves very little purpose.  Can
it be simply deleted?

static unsigned long omap_mpu_timer2_overflows;

static irqreturn_t omap_mpu_timer2_interrupt(int irq, void *dev_id)
{
        omap_mpu_timer2_overflows++;
        return IRQ_HANDLED;
}

static struct irqaction omap_mpu_timer2_irq = {
        .name           = "mpu_timer2",
        .flags          = IRQF_DISABLED,
        .handler        = omap_mpu_timer2_interrupt,
};

...
static void __init omap_init_clocksource(unsigned long rate)
{
...
        setup_irq(INT_TIMER2, &omap_mpu_timer2_irq);
...
}

             reply	other threads:[~2011-05-08 16:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-08 16:28 Russell King - ARM Linux [this message]
2011-05-09  6:03 ` OMAP1: unnecessary timer interrupt handler code? Tony Lindgren
2011-05-10 12:26   ` Kevin Hilman
2011-05-10 18:31     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110508162800.GM27807@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).