OMAP1: unnecessary timer interrupt handler code?

OMAP1: unnecessary timer interrupt handler code?

[Russell King - ARM Linux]

MPU timer 2 is used on OMAP1 for the clock source and scheduler clock.
It registers an interrupt, which counts the number of overflows of
this timer.  However, this counter is only referenced by the interrupt
handler.

So, it seems that the following code serves very little purpose.  Can
it be simply deleted?

static unsigned long omap_mpu_timer2_overflows;

static irqreturn_t omap_mpu_timer2_interrupt(int irq, void *dev_id)
{
        omap_mpu_timer2_overflows++;
        return IRQ_HANDLED;
}

static struct irqaction omap_mpu_timer2_irq = {
        .name           = "mpu_timer2",
        .flags          = IRQF_DISABLED,
        .handler        = omap_mpu_timer2_interrupt,
};

...
static void __init omap_init_clocksource(unsigned long rate)
{
...
        setup_irq(INT_TIMER2, &omap_mpu_timer2_irq);
...
}

Re: OMAP1: unnecessary timer interrupt handler code?

[Tony Lindgren]

* Russell King - ARM Linux <linux@arm.linux.org.uk> [110508 19:24]:
> MPU timer 2 is used on OMAP1 for the clock source and scheduler clock.
> It registers an interrupt, which counts the number of overflows of
> this timer.  However, this counter is only referenced by the interrupt
> handler.
> 
> So, it seems that the following code serves very little purpose.  Can
> it be simply deleted?

Seems safe to me. This is probably some left over legacy code
from long time ago.

Regards,

Tony

Re: OMAP1: unnecessary timer interrupt handler code?

[Kevin Hilman]

Tony Lindgren <tony@atomide.com> writes:

> * Russell King - ARM Linux <linux@arm.linux.org.uk> [110508 19:24]:
>> MPU timer 2 is used on OMAP1 for the clock source and scheduler clock.
>> It registers an interrupt, which counts the number of overflows of
>> this timer.  However, this counter is only referenced by the interrupt
>> handler.
>> 
>> So, it seems that the following code serves very little purpose.  Can
>> it be simply deleted?
>
> Seems safe to me. This is probably some left over legacy code
> from long time ago.

Yes, I believe this is left over legacy code and can be removed.

Russell, feel free to remove it, or let me know if you want a patch from
me.  If you do it, feel free add

Acked-by: Kevin Hilman <khilman@ti.com>

Re: OMAP1: unnecessary timer interrupt handler code?

[Russell King - ARM Linux]

On Tue, May 10, 2011 at 02:26:57PM +0200, Kevin Hilman wrote:
> Tony Lindgren <tony@atomide.com> writes:
> 
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [110508 19:24]:
> >> MPU timer 2 is used on OMAP1 for the clock source and scheduler clock.
> >> It registers an interrupt, which counts the number of overflows of
> >> this timer.  However, this counter is only referenced by the interrupt
> >> handler.
> >> 
> >> So, it seems that the following code serves very little purpose.  Can
> >> it be simply deleted?
> >
> > Seems safe to me. This is probably some left over legacy code
> > from long time ago.
> 
> Yes, I believe this is left over legacy code and can be removed.
> 
> Russell, feel free to remove it, or let me know if you want a patch from
> me.  If you do it, feel free add
> 
> Acked-by: Kevin Hilman <khilman@ti.com>

Thanks, added the ack to the patch.  (See the series I posted this morning).