From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Kevin Hilman <khilman@ti.com>
Cc: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Subject: Re: OMAP1: unnecessary timer interrupt handler code?
Date: Tue, 10 May 2011 19:31:18 +0100 [thread overview]
Message-ID: <20110510183118.GA5336@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <87y62e4u7h.fsf@ti.com>
On Tue, May 10, 2011 at 02:26:57PM +0200, Kevin Hilman wrote:
> Tony Lindgren <tony@atomide.com> writes:
>
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [110508 19:24]:
> >> MPU timer 2 is used on OMAP1 for the clock source and scheduler clock.
> >> It registers an interrupt, which counts the number of overflows of
> >> this timer. However, this counter is only referenced by the interrupt
> >> handler.
> >>
> >> So, it seems that the following code serves very little purpose. Can
> >> it be simply deleted?
> >
> > Seems safe to me. This is probably some left over legacy code
> > from long time ago.
>
> Yes, I believe this is left over legacy code and can be removed.
>
> Russell, feel free to remove it, or let me know if you want a patch from
> me. If you do it, feel free add
>
> Acked-by: Kevin Hilman <khilman@ti.com>
Thanks, added the ack to the patch. (See the series I posted this morning).
prev parent reply other threads:[~2011-05-10 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 16:28 OMAP1: unnecessary timer interrupt handler code? Russell King - ARM Linux
2011-05-09 6:03 ` Tony Lindgren
2011-05-10 12:26 ` Kevin Hilman
2011-05-10 18:31 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510183118.GA5336@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).