From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: "Munegowda, Keshava" <keshava_mgowda-l0cyMroinI0@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gadiyar-l0cyMroinI0@public.gmane.org,
p-bask2-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH] omap: usbhs: Fixed the crash during rmmod of ehci and ohci
Date: Wed, 11 May 2011 12:08:36 +0300 [thread overview]
Message-ID: <20110511090834.GN2505@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <BANLkTi=F5g50mxw6VBv7-di7hH_eDEZ=GA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi,
On Mon, May 09, 2011 at 03:58:53PM +0530, Munegowda, Keshava wrote:
> I you see only the patch ; its looks like variable halt is not needed;
>
> If the code; it will be set only when the clocks are disabled;
> Then after restoring irq, you will free the gpio based on this value.
that code is wrong in so many ways that it's difficult to reply, but in
short:
. get rid of the magic constants, define some macros
. instead of using only one error label, use several each one taking
care of a different case (that will allow you to remove halt flag)
. timeout is never reset, meaning after the first loop, the time_after()
will always be true.
. this omap->count is ugly.
. you shouldn't be accessing pdata on the exit path
. that save in spin_lock_irqsave() looks unnecessary. Wouldn't
spin_lock_irq() be enough ?
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-11 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 9:10 [PATCH] omap: usbhs: Fixed the crash during rmmod of ehci and ohci Keshava Munegowda
[not found] ` <1304932203-31223-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-05-09 9:36 ` Felipe Balbi
2011-05-09 10:28 ` Munegowda, Keshava
[not found] ` <BANLkTi=F5g50mxw6VBv7-di7hH_eDEZ=GA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-11 9:08 ` Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-16 8:52 Keshava Munegowda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511090834.GN2505@legolas.emea.dhcp.ti.com \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=gadiyar-l0cyMroinI0@public.gmane.org \
--cc=keshava_mgowda-l0cyMroinI0@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=p-bask2-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).