From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Graeme Gregory <gg@slimlogic.co.uk>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
sameo@linux.intel.com, balbi@ti.com, lrg@slimlogic.co.uk
Subject: Re: [PATCH v2 1/4] MFD: TWL6025: add phoenix lite support to twl6030
Date: Thu, 12 May 2011 15:24:43 +0100 [thread overview]
Message-ID: <20110512142443.GA16218@sirena.org.uk> (raw)
In-Reply-To: <1305206878-18094-2-git-send-email-gg@slimlogic.co.uk>
On Thu, May 12, 2011 at 02:27:55PM +0100, Graeme Gregory wrote:
> Phoenix Lite is based on the twl6030 family of PMICs. It has mostly the
> same feature set of twl6030 but with small changes. The codec block has
> also been removed. It also has a new charger block and new features in
> its ADC block. VUSB handling also differs.
Reviewed-by: Mark Brown <broonie@opensource.wolfsonicro.com>
> + pdata->driver_data = (void *)features;
> +
You never need to cast to void, and doing needless casts can mask bugs.
next prev parent reply other threads:[~2011-05-12 14:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 13:27 [PATCH v2 0/4] Add support for twl6025 PMIC Graeme Gregory
2011-05-12 13:27 ` [PATCH v2 1/4] MFD: TWL6025: add phoenix lite support to twl6030 Graeme Gregory
2011-05-12 14:24 ` Mark Brown [this message]
2011-05-13 14:47 ` Samuel Ortiz
2011-05-12 13:27 ` [PATCH v2 2/4] MFD: TWL6030: fix irq definitions Graeme Gregory
2011-05-13 14:48 ` Samuel Ortiz
2011-05-12 13:27 ` [PATCH v2 3/4] REGULATOR: TWL6025: add support to twl-regulator Graeme Gregory
2011-05-14 16:12 ` Mark Brown
2011-05-16 9:08 ` T Krishnamoorthy, Balaji
2011-05-18 14:17 ` Graeme Gregory
2011-05-18 14:32 ` Liam Girdwood
2011-05-12 13:27 ` [PATCH v2 4/4] USB: TWL6025 allow different regulator name Graeme Gregory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512142443.GA16218@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=balbi@ti.com \
--cc=gg@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).