From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH] omap:pm: Fix boot-time errors with debugfs disabled Date: Thu, 12 May 2011 14:03:36 -0700 Message-ID: <20110512210333.GA5775@olorun> References: <1305221790-4944-1-git-send-email-premi@ti.com> <20110512195841.GA13651@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aob106.obsmtp.com ([74.125.149.76]:37607 "EHLO na3sys009aog106.obsmtp.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758559Ab1ELU7P (ORCPT ); Thu, 12 May 2011 16:59:15 -0400 Received: by mail-yw0-f52.google.com with SMTP id 7so959921ywo.11 for ; Thu, 12 May 2011 13:59:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20110512195841.GA13651@google.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Todd Poynor Cc: "Premi, Sanjeev" , "linux-omap@vger.kernel.org" On 12:58-20110512, Todd Poynor wrote: > On Fri, May 13, 2011 at 12:46:17AM +0530, Premi, Sanjeev wrote: > > > -----Original Message----- > > > From: Menon, Nishanth > ... > > > Last I tried, with Vishwa's dvfs branch on panda without voltage > > > registrations, things could crash :( if I get some time I will try to > > > port Vishwa's series onto kevin's branch as well and test and provide > > > any patches necessary. > > > > [sp] I can try this on Panda. Will be able to get one tomorrow. > > In case it helps, below is what I use for Panda. > > --- > ARM: OMAP2 voltage: Don't die if board does not register voltage params > > This allows the DVFS patches to boot on boards not yet modified to > register voltage params. > > Signed-off-by: Todd Poynor > --- > arch/arm/mach-omap2/voltage.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c > index dbc1cfe..8f23d95 100644 > --- a/arch/arm/mach-omap2/voltage.c > +++ b/arch/arm/mach-omap2/voltage.c > @@ -617,6 +617,12 @@ static void __init omap4_vc_init(struct omap_vdd_info *vdd) > struct clk *sys_ck; > u32 sys_clk_speed; > > + if (!vdd->board_data) { > + pr_warning("%s: No voltage board params registered for vdd_%s\n", > + __func__, vdd->voltdm.name); > + return; > + } > + > sys_ck = clk_get(NULL, "sys_clkin_ck"); > if (IS_ERR(sys_ck)) { > pr_warning("%s: Could not get the sys clk to calculate" looks around the right place.. but, which branch is this based on? cant see board_data on linus master.. -- Regards, Nishanth Menon