linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	linux-omap@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
	Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time
Date: Tue, 17 May 2011 15:57:00 +0300	[thread overview]
Message-ID: <20110517125700.GY5323@atomide.com> (raw)
In-Reply-To: <20110517152954.477365e6.jhnikula@gmail.com>

* Jarkko Nikula <jhnikula@gmail.com> [110517 15:24]:
> On Tue, 17 May 2011 13:33:40 +0300
> Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> 
> > On OMAP4 we have one interrupt line per McBSP port.
> > At proble time tx, and rx irq value will be -ENXIO,
> > and only the tx irq will get corrected.
> > In omap_mcbsp_request if the rx_irq is not 0 we proceed,
> > and try to request the interrupt, which will fail on
> > OMAP4 (rx_irq == -6).
> > To avoid this error, clear the rx_irq at probe time
> > on OMAP4.
> > 
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > ---
> >  arch/arm/plat-omap/mcbsp.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> Acked-by: Jarkko Nikula <jhnikula@gmail.com>

This file should be under drivers/ somewhere, can you
guys please take care of that?

Regards,

Tony

  reply	other threads:[~2011-05-17 12:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-17 10:33 [PATCH] OMAP4: McBSP: Clear rx_irq at probe time Peter Ujfalusi
2011-05-17 12:29 ` Jarkko Nikula
2011-05-17 12:57   ` Tony Lindgren [this message]
2011-05-18  5:52     ` Peter Ujfalusi
2011-05-18  7:59       ` Jarkko Nikula
2011-05-31  7:52         ` Tony Lindgren
2011-05-18 12:39     ` Peter Ujfalusi
2011-05-31  7:57       ` Tony Lindgren
2011-06-08  7:51         ` Peter Ujfalusi
2011-06-13 13:35           ` Tony Lindgren
2011-06-14 11:19             ` Péter Ujfalusi
2011-06-14 12:05               ` Jarkko Nikula
2011-06-14 12:40                 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110517125700.GY5323@atomide.com \
    --to=tony@atomide.com \
    --cc=jhnikula@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).