From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time Date: Tue, 17 May 2011 15:57:00 +0300 Message-ID: <20110517125700.GY5323@atomide.com> References: <1305628420-10592-1-git-send-email-peter.ujfalusi@ti.com> <20110517152954.477365e6.jhnikula@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:31364 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754620Ab1EQM5H (ORCPT ); Tue, 17 May 2011 08:57:07 -0400 Content-Disposition: inline In-Reply-To: <20110517152954.477365e6.jhnikula@gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Jarkko Nikula Cc: Peter Ujfalusi , linux-omap@vger.kernel.org, Liam Girdwood , Kishon Vijay Abraham I * Jarkko Nikula [110517 15:24]: > On Tue, 17 May 2011 13:33:40 +0300 > Peter Ujfalusi wrote: > > > On OMAP4 we have one interrupt line per McBSP port. > > At proble time tx, and rx irq value will be -ENXIO, > > and only the tx irq will get corrected. > > In omap_mcbsp_request if the rx_irq is not 0 we proceed, > > and try to request the interrupt, which will fail on > > OMAP4 (rx_irq == -6). > > To avoid this error, clear the rx_irq at probe time > > on OMAP4. > > > > Signed-off-by: Peter Ujfalusi > > --- > > arch/arm/plat-omap/mcbsp.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > Acked-by: Jarkko Nikula This file should be under drivers/ somewhere, can you guys please take care of that? Regards, Tony