From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [v2 0/7] OMAP: GPIO: Use PM runtime framework Date: Thu, 19 May 2011 13:08:41 -0600 Message-ID: <20110519190841.GJ5109@ponder.secretlab.ca> References: <87r58w4gq3.fsf@ti.com> <20110421054221.GF5918@atomide.com> <20110426072941.GA3755@atomide.com> <87y62ng3f8.fsf@ti.com> <20110504061905.GD27860@atomide.com> <87mxiscl0w.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-px0-f173.google.com ([209.85.212.173]:61384 "EHLO mail-px0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757078Ab1ESTIo (ORCPT ); Thu, 19 May 2011 15:08:44 -0400 Received: by pxi16 with SMTP id 16so1985327pxi.4 for ; Thu, 19 May 2011 12:08:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87mxiscl0w.fsf@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: Linus Walleij , Tony Lindgren , paul@pwsan.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Varadarajan, Charulatha" On Thu, May 12, 2011 at 11:42:39AM +0200, Kevin Hilman wrote: > Linus Walleij writes: > > [...] > > > For TI I guess this currently means you simply cannot work > > on GPIO stuff until you know where to go with it unless you > > allow the OMAP GPIO authors to keep churning in arch/arm/*... > > > > That's unless Grant is OK with us moving stuff into > > drivers/gpio that does *not* use gpiolib and utilize singletons to > > get at the gpio_chip addresses (i.e. current form) and keep it > > churning like that until it can be refactored. > > The churn will happen one way or another. the only question is whether > it happens in drivers/gpio or arch/arm/*. > > Grant, what's your feeling here. How much ugliness are you willing to > tolerate in a bulk move to drivers/gpio. At least for OMAP, I am > personally be working on the cleanup/move so I can work either way, > although I know Tony has an obvious preference for moving it to > drivers/gpio. :) > > The OMAP driver is already using gpiolib. The main ugliness in the OMAP > driver is the awful ifdeffery used to handle the differences across the > various SoCs in the OMAP family. I've already got most of that cleaned > up[1]. Go ahead and move stuff. I may as well have the junk in my tree. I request however to have at least some semblance of organization. I'd like each driver filename to be named something like gpio_*.c, and put things into the Makefile/Kconfig in alphabetical order as much as possible. Also, for an awful lot of these SoC gpio controllers there is almost zero value in having a user visible Kconfig entry for it because they are so tiny. I'd rather see on-chip gpio controllers configured in automatically without any user selectable options. g.