From: Samuel Ortiz <sameo@linux.intel.com>
To: "Manuel, Lesly Arackal" <leslyam@ti.com>
Cc: linux-omap@vger.kernel.org, Nishanth Menon <nm@ti.com>,
David Derrick <dderrick@ti.com>
Subject: Re: [PATCH v10 4/7] MFD: TWL4030: power scripts for OMAP3 boards
Date: Sun, 22 May 2011 23:40:37 +0200 [thread overview]
Message-ID: <20110522214036.GO18610@sortiz-mobl> (raw)
In-Reply-To: <BANLkTi=c9naYFuuRbNG8FK6WuKWVBp0DKg@mail.gmail.com>
Hi Lesly,
On Tue, May 17, 2011 at 07:10:03PM +0530, Manuel, Lesly Arackal wrote:
> Hi Samuel,
>
> On Sat, May 14, 2011 at 12:09 AM, Samuel Ortiz <sameo@linux.intel.com> wrote:
> > Hi Lesly,
> >
> > On Fri, May 06, 2011 at 06:47:10PM +0530, Lesly A M wrote:
> >> Power bus message sequence for TWL4030 to enter sleep/wakeup/warm_reset.
> >>
> >> TWL4030 power scripts which can be used by different OMAP3 boards
> >> with the power companion chip (TWL4030 series).
> >>
> >> The twl4030 generic script can be used by any board file to update
> >> the power data in twl4030_platform_data.
> >>
> >> Since the TWL4030 power script has dependency with APIs in twl4030-power.c
> >> removing the __init for these APIs.
> >>
> >> For more information please see:
> >> http://omapedia.org/wiki/TWL4030_power_scripts
> > I understand you guys are trying to keep the arch/arm stats to a sane level,
> > but I don't see why this driver should be under drivers/mfd/. I'm usually
> > flexible about what goes into drivers/mfd, but this one seems out of context
> > to me.
>
> Since this script driver file contains the changes for PM IC (TWL4030 series),
> which is a Multifunction devices with GPIOs, USB, audio,
> current regulators, power management chip, ...
>
> This script driver file contains the pm bus message sequence which will be
> programmed in the scratch memory of the PM IC, and some resource configuration
> data for PM IC resources.
>
> This change was suggested by Tony for the last version of this patch series.
I understand, but I'm trying to get the "let's push everything that somehow
linked to our MFD driver to drivers/mfd/" crazyness down to a sane level.
This one doesn't look like it should be part of drivers/mfd.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-22 21:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 13:17 [PATCH v10 0/7] MFD: TWL4030: power script and workaround for erratum 27 Lesly A M
2011-05-06 13:17 ` [PATCH v10 1/7] MFD: TWL4030: Fix for the TWL4030 sleep/wakeup sequence Lesly A M
2011-05-13 12:40 ` Kevin Hilman
2011-05-13 17:14 ` Samuel Ortiz
2011-05-06 13:17 ` [PATCH v10 2/7] MFD: TWL4030: Correct the warning print during script loading Lesly A M
2011-05-13 17:19 ` Samuel Ortiz
2011-05-06 13:17 ` [PATCH v10 3/7] MFD: TWL4030: Modifying the macro name Main_Ref to all caps Lesly A M
2011-05-12 10:42 ` Tony Lindgren
2011-05-13 7:12 ` Manuel, Lesly Arackal
2011-05-13 17:20 ` Samuel Ortiz
2011-05-06 13:17 ` [PATCH v10 4/7] MFD: TWL4030: power scripts for OMAP3 boards Lesly A M
2011-05-12 10:56 ` Tony Lindgren
2011-05-13 7:53 ` Manuel, Lesly Arackal
2011-05-13 18:39 ` Samuel Ortiz
2011-05-17 13:40 ` Manuel, Lesly Arackal
2011-05-22 21:40 ` Samuel Ortiz [this message]
2011-05-24 12:17 ` Manuel, Lesly Arackal
2011-06-02 18:29 ` Kevin Hilman
2011-06-06 14:03 ` Manuel, Lesly Arackal
2011-06-06 16:08 ` Kevin Hilman
2011-05-06 13:17 ` [PATCH v10 5/7] MFD: TWL4030: TWL version checking Lesly A M
2011-05-13 17:22 ` Samuel Ortiz
2011-05-06 13:17 ` [PATCH v10 6/7] MFD: TWL4030: workaround changes for Erratum 27 Lesly A M
2011-05-06 13:17 ` [PATCH v10 7/7] MFD: TWL4030: optimizing resource configuration Lesly A M
2011-06-02 15:36 ` [PATCH v10 0/7] MFD: TWL4030: power script and workaround for erratum 27 Steve Sakoman
2011-06-02 17:12 ` Steve Sakoman
2011-06-03 0:31 ` Kevin Hilman
2011-06-06 14:05 ` Manuel, Lesly Arackal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110522214036.GO18610@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=dderrick@ti.com \
--cc=leslyam@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).