* [PATCH] ARM: OMAP2: Add missing iounmap in omap4430_phy_init
@ 2011-05-26 19:25 Todd Poynor
2011-05-31 11:55 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Todd Poynor @ 2011-05-26 19:25 UTC (permalink / raw)
To: Tony Lindgren, linux-omap, Hema HK
!dev case needs iounmap before return.
Signed-off-by: Todd Poynor <toddpoynor@google.com>
---
arch/arm/mach-omap2/omap_phy_internal.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_phy_internal.c b/arch/arm/mach-omap2/omap_phy_internal.c
index ae97336..bd563cf 100644
--- a/arch/arm/mach-omap2/omap_phy_internal.c
+++ b/arch/arm/mach-omap2/omap_phy_internal.c
@@ -56,8 +56,10 @@ int omap4430_phy_init(struct device *dev)
/* Power down the phy */
__raw_writel(PHY_PD, ctrl_base + CONTROL_DEV_CONF);
- if (!dev)
+ if (!dev) {
+ iounmap(ctrl_base);
return 0;
+ }
phyclk = clk_get(dev, "ocp2scp_usb_phy_ick");
if (IS_ERR(phyclk)) {
--
1.7.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: OMAP2: Add missing iounmap in omap4430_phy_init
2011-05-26 19:25 [PATCH] ARM: OMAP2: Add missing iounmap in omap4430_phy_init Todd Poynor
@ 2011-05-31 11:55 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2011-05-31 11:55 UTC (permalink / raw)
To: Todd Poynor; +Cc: linux-omap, Hema HK
* Todd Poynor <toddpoynor@google.com> [110526 12:22]:
> !dev case needs iounmap before return.
Adding to fixes thanks.
Tony
> Signed-off-by: Todd Poynor <toddpoynor@google.com>
> ---
> arch/arm/mach-omap2/omap_phy_internal.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_phy_internal.c b/arch/arm/mach-omap2/omap_phy_internal.c
> index ae97336..bd563cf 100644
> --- a/arch/arm/mach-omap2/omap_phy_internal.c
> +++ b/arch/arm/mach-omap2/omap_phy_internal.c
> @@ -56,8 +56,10 @@ int omap4430_phy_init(struct device *dev)
> /* Power down the phy */
> __raw_writel(PHY_PD, ctrl_base + CONTROL_DEV_CONF);
>
> - if (!dev)
> + if (!dev) {
> + iounmap(ctrl_base);
> return 0;
> + }
>
> phyclk = clk_get(dev, "ocp2scp_usb_phy_ick");
> if (IS_ERR(phyclk)) {
> --
> 1.7.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-31 11:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-26 19:25 [PATCH] ARM: OMAP2: Add missing iounmap in omap4430_phy_init Todd Poynor
2011-05-31 11:55 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).