From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3.0-rc1] OMAP: fix compilation error
Date: Mon, 30 May 2011 23:21:07 +0100 [thread overview]
Message-ID: <20110530222107.GA21753@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <201105302344.01530.jkrzyszt@tis.icnet.pl>
On Mon, May 30, 2011 at 11:44:01PM +0200, Janusz Krzysztofik wrote:
> Include <linux/platform_device.h> from
> arch/arm/plat-omap/include/plat/flash.h, otherwise compilation may break
> with:
>
> In file included from arch/arm/mach-omap1/flash.c:15:
> arch/arm/plat-omap/include/plat/flash.h:14: warning: 'struct platform_device' declared inside parameter list
> arch/arm/plat-omap/include/plat/flash.h:14: warning: its scope is only this definition or declaration, which is probably not what you want
> arch/arm/mach-omap1/flash.c:16: warning: 'struct platform_device' declared inside parameter list
> arch/arm/mach-omap1/flash.c:17: error: conflicting types for 'omap1_set_vpp'
> arch/arm/plat-omap/include/plat/flash.h:14: error: previous declaration of 'omap1_set_vpp' was here
Just forward-declare the struct by adding:
struct platform_device;
in this header; there's no need to add to the complexities of header file
inclusion...
next prev parent reply other threads:[~2011-05-30 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 21:44 [PATCH 3.0-rc1] OMAP: fix compilation error Janusz Krzysztofik
2011-05-30 22:21 ` Russell King - ARM Linux [this message]
2011-05-30 22:44 ` [PATCH 3.0-rc1 v2] " Janusz Krzysztofik
2011-05-31 6:41 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110530222107.GA21753@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).