From: Tony Lindgren <tony@atomide.com>
To: Rabin Vincent <rabin@rab.in>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] OMAP4: fix return value of omap4_l3_init
Date: Tue, 31 May 2011 04:52:04 -0700 [thread overview]
Message-ID: <20110531115204.GA11352@atomide.com> (raw)
In-Reply-To: <1304787527-8314-1-git-send-email-rabin@rab.in>
* Rabin Vincent <rabin@rab.in> [110507 09:54]:
> Don't PTR_ERR() a non-error pointer:
>
> initcall omap4_l3_init+0x0/0xdc returned -544980480 after 0 usecs
> initcall omap4_l3_init+0x0/0xdc returned with error code -544980480
Adding to fixes thanks.
Tony
> Signed-off-by: Rabin Vincent <rabin@rab.in>
> ---
> arch/arm/mach-omap2/devices.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 7b85585..5b8ca68 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -97,7 +97,7 @@ static int __init omap4_l3_init(void)
>
> WARN(IS_ERR(od), "could not build omap_device for %s\n", oh_name);
>
> - return PTR_ERR(od);
> + return IS_ERR(od) ? PTR_ERR(od) : 0;
> }
> postcore_initcall(omap4_l3_init);
>
> --
> 1.7.4.1
>
prev parent reply other threads:[~2011-05-31 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 16:58 [PATCH] OMAP4: fix return value of omap4_l3_init Rabin Vincent
2011-05-18 15:53 ` Rabin Vincent
2011-05-31 11:52 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531115204.GA11352@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).