From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2] arm: omap3: cm-t35: add support for cm-t3730 Date: Tue, 31 May 2011 06:04:47 -0700 Message-ID: <20110531130447.GK11352@atomide.com> References: <4DC27317.7020206@compulab.co.il> <1304839231-11329-1-git-send-email-grinberg@compulab.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:36744 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751500Ab1EaNEu (ORCPT ); Tue, 31 May 2011 09:04:50 -0400 Content-Disposition: inline In-Reply-To: <1304839231-11329-1-git-send-email-grinberg@compulab.co.il> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Igor Grinberg Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org * Igor Grinberg [110508 00:17]: > cm-t3730 is basically the same board as cm-t35, but has DM3730 SoC > assembled and therefore some changes are required. > +static void cm_t35_mux_init(void) > +{ > + int mux_mode = OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT; > + > + omap3_mux_init(cm_t35_common_board_mux, OMAP_PACKAGE_CUS); > + > + if (cpu_is_omap34xx()) { > + omap_mux_init_signal("gpio_70", mux_mode); > + omap_mux_init_signal("gpio_71", mux_mode); > + omap_mux_init_signal("gpio_72", mux_mode); > + omap_mux_init_signal("gpio_73", mux_mode); > + omap_mux_init_signal("gpio_74", mux_mode); > + omap_mux_init_signal("gpio_75", mux_mode); > + } else if (cpu_is_omap3630()) { > + mux_mode = OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT; > + omap_mux_init_signal("sys_boot0", mux_mode); > + omap_mux_init_signal("sys_boot1", mux_mode); > + omap_mux_init_signal("sys_boot3", mux_mode); > + omap_mux_init_signal("sys_boot4", mux_mode); > + omap_mux_init_signal("sys_boot5", mux_mode); > + omap_mux_init_signal("sys_boot6", mux_mode); > + } > + > + omap_mux_init_signal("dss_data18", mux_mode); > + omap_mux_init_signal("dss_data19", mux_mode); > + omap_mux_init_signal("dss_data20", mux_mode); > + omap_mux_init_signal("dss_data21", mux_mode); > + omap_mux_init_signal("dss_data22", mux_mode); > + omap_mux_init_signal("dss_data23", mux_mode); > +} > +#else > +static inline void cm_t35_mux_init(void) {} > #endif Should this cpu_is_omap if else done once and then set some data based on it? That would be better if you need to use it for detection for other things later on as it will avoid multiple cpu_is/machine_is if else lines of code. Regards, Tony