From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Nori, Sekhar" <nsekhar@ti.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Hilman, Kevin" <khilman@ti.com>,
Tony Lindgren <tony@atomide.com>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [RFC PATCH v4] Consolidate SRAM support
Date: Tue, 31 May 2011 22:21:42 +0100 [thread overview]
Message-ID: <20110531212142.GA6700@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593024D234457@dbde02.ent.ti.com>
On Tue, May 31, 2011 at 10:39:48PM +0530, Nori, Sekhar wrote:
> I also found some check patch errors. Feel free to merge
> the attached patch.
And this introduces another style issue...
> diff --git a/arch/arm/plat-mxc/include/mach/iram.h b/arch/arm/plat-mxc/include/mach/iram.h
> index 8279c47..aae5e35 100644
> --- a/arch/arm/plat-mxc/include/mach/iram.h
> +++ b/arch/arm/plat-mxc/include/mach/iram.h
> @@ -31,7 +31,7 @@ static inline void *iram_alloc(size_t size, phys_addr_t *phys)
>
> *phys = gen_pool_virt_to_phys(iram_pool, addr);
>
> - return (void*)addr;
> + return (void *) addr;
The style here is:
return (void *)addr;
next prev parent reply other threads:[~2011-05-31 21:22 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 13:06 [RFC PATCH] Consolidate SRAM support Russell King - ARM Linux
2011-04-15 13:39 ` Rob Herring
2011-04-15 14:02 ` Ithamar R. Adema
2011-04-15 14:40 ` Arnd Bergmann
2011-04-15 15:26 ` Russell King - ARM Linux
2011-04-15 15:32 ` Grant Likely
2011-04-15 15:41 ` Russell King - ARM Linux
2011-04-16 4:11 ` Magnus Damm
2011-04-17 17:47 ` Arnd Bergmann
2011-04-15 16:03 ` Russell King - ARM Linux
2011-04-15 16:18 ` Nguyen Dinh-R00091
2011-04-15 16:20 ` Russell King - ARM Linux
2011-04-15 16:58 ` Russell King - ARM Linux
2011-04-15 19:20 ` Nguyen Dinh-R00091
2011-04-15 19:40 ` Russell King - ARM Linux
2011-04-15 20:06 ` Nguyen Dinh-R00091
2011-04-15 13:52 ` Eduardo Valentin
2011-04-15 15:24 ` Russell King - ARM Linux
2011-04-15 14:50 ` Detlef Vollmann
2011-04-15 15:37 ` Russell King - ARM Linux
2011-04-15 18:12 ` Detlef Vollmann
2011-04-15 18:21 ` Russell King - ARM Linux
2011-04-15 16:04 ` Nicolas Ferre
2011-04-15 18:14 ` Detlef Vollmann
2011-04-16 11:27 ` Detlef Vollmann
2011-04-15 18:31 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-15 20:11 ` Uwe Kleine-König
2011-04-15 20:19 ` Russell King - ARM Linux
2011-04-15 20:22 ` Uwe Kleine-König
2011-04-16 13:01 ` Haojian Zhuang
2011-04-16 13:09 ` Russell King - ARM Linux
2011-04-18 6:48 ` Tony Lindgren
2011-04-18 7:00 ` Tomi Valkeinen
2011-04-18 8:17 ` Tony Lindgren
2011-04-19 14:16 ` Tomi Valkeinen
2011-04-20 5:27 ` Tony Lindgren
2011-04-18 8:52 ` [RFC PATCH v2] " Russell King - ARM Linux
2011-04-18 9:31 ` Haojian Zhuang
2011-04-18 11:33 ` Tony Lindgren
2011-04-18 13:50 ` Detlef Vollmann
2011-04-18 16:12 ` Nori, Sekhar
2011-04-18 16:18 ` Russell King - ARM Linux
2011-04-19 16:01 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-19 16:18 ` Russell King - ARM Linux
2011-04-19 19:05 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-19 23:20 ` Russell King - ARM Linux
2011-04-20 4:06 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-19 1:23 ` [RFC PATCH] " Linus Walleij
2011-05-12 17:45 ` [RFC PATCH v3] " Russell King - ARM Linux
2011-05-12 18:35 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-13 7:30 ` Jean Pihet
2011-05-13 9:11 ` Russell King - ARM Linux
2011-05-13 9:25 ` Jean Pihet
2011-05-13 9:19 ` Santosh Shilimkar
2011-05-17 13:06 ` Nori, Sekhar
2011-05-26 1:02 ` [RFC PATCH v4] " Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1306371777-20431-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2011-05-31 17:09 ` Nori, Sekhar
2011-05-31 21:21 ` Russell King - ARM Linux [this message]
2011-06-29 13:12 ` Nori, Sekhar
2011-07-08 16:51 ` Nori, Sekhar
2011-07-08 16:58 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531212142.GA6700@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=kernel@pengutronix.de \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=plagnioj@jcrosoft.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).