linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/3] OMAP2+: fix compilation warnings.
@ 2011-06-01  5:58 Govindraj.R
  2011-06-01  7:27 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Govindraj.R @ 2011-06-01  5:58 UTC (permalink / raw)
  To: linux-omap; +Cc: Tony Lindgren, Govindraj.R

Fix below compilation warnings.

arch/arm/mach-omap2/omap_hwmod.c: In function 'omap_hwmod_for_each':
arch/arm/mach-omap2/omap_hwmod.c:1631: warning: 'ret' may be used uninitialized in this function

arch/arm/mach-omap2/mux.c: In function 'omap_mux_get_gpio':
arch/arm/mach-omap2/mux.c:917: warning: 'm' may be used uninitialized in this function

Signed-off-by: Govindraj.R <govindraj.raja@ti.com>
---
 arch/arm/mach-omap2/mux.c        |    2 +-
 arch/arm/mach-omap2/omap_hwmod.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
index a4ab1e3..b4f9066 100644
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
@@ -906,7 +906,7 @@ static struct omap_mux *omap_mux_get_by_gpio(
 u16 omap_mux_get_gpio(int gpio)
 {
 	struct omap_mux_partition *partition;
-	struct omap_mux *m;
+	struct omap_mux *m = NULL;
 
 	list_for_each_entry(partition, &mux_partitions, node) {
 		m = omap_mux_get_by_gpio(partition, gpio);
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index e034294..293fa6c 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -1628,7 +1628,7 @@ int omap_hwmod_for_each(int (*fn)(struct omap_hwmod *oh, void *data),
 			void *data)
 {
 	struct omap_hwmod *temp_oh;
-	int ret;
+	int ret = 0;
 
 	if (!fn)
 		return -EINVAL;
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/3] OMAP2+: fix compilation warnings.
  2011-06-01  5:58 [PATCH 2/3] OMAP2+: fix compilation warnings Govindraj.R
@ 2011-06-01  7:27 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2011-06-01  7:27 UTC (permalink / raw)
  To: Govindraj.R; +Cc: linux-omap

* Govindraj.R <govindraj.raja@ti.com> [110531 22:54]:
> Fix below compilation warnings.
> 
> arch/arm/mach-omap2/omap_hwmod.c: In function 'omap_hwmod_for_each':
> arch/arm/mach-omap2/omap_hwmod.c:1631: warning: 'ret' may be used uninitialized in this function
> 
> arch/arm/mach-omap2/mux.c: In function 'omap_mux_get_gpio':
> arch/arm/mach-omap2/mux.c:917: warning: 'm' may be used uninitialized in this function

Thanks, applying into devel-fixes. Whee, is the only warning now
remaining the h4 keypad warning?

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-06-01  7:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-01  5:58 [PATCH 2/3] OMAP2+: fix compilation warnings Govindraj.R
2011-06-01  7:27 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).