From mboxrd@z Thu Jan 1 00:00:00 1970 From: Todd Poynor Subject: Re: [PATCH] ARM: omap4: gpio: fix setting IRQWAKEN bits Date: Mon, 6 Jun 2011 16:05:22 -0700 Message-ID: <20110606230522.GA16590@google.com> References: <1307214239-16316-1-git-send-email-ccross@android.com> <87r576wpz6.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <87r576wpz6.fsf@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Kevin Hilman Cc: l-o , Tony Lindgren , Russell King , "linux-arm-kernel@lists.infradead.org" , lkml , Colin Cross List-Id: linux-omap@vger.kernel.org On Mon, Jun 06, 2011 at 03:32:29PM -0700, Kevin Hilman wrote: > Colin Cross writes: >=20 > > On Sat, Jun 4, 2011 at 12:03 PM, Colin Cross w= rote: > >> Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits, > >> causing only the last bit set to take effect, resulting in lost > >> wakeups when the GPIO controller is in idle. > >> > >> Replace direct writes to IRQWAKEN with writes to SETWKUENA and > >> CLEARWKUEN. > >> > >> Signed-off-by: Colin Cross >=20 > [...] >=20 > > > > Todd pointed out that the OMAP4 TRM says not to use SETWKUENA and > > CLEARWKUENA. =20 >=20 > In my GPIO cleanups, I was wondering why the set/clear registers were > not used here. Todd, can you give the TRM version & reference for thi= s? > I didn't find anything after a quick scan/search. http://focus.ti.com/general/docs/wtbu/wtbudocumentcenter.tsp?templateId= =3D6123&navigationId=3D12037 OMAP4460 Multimedia Device Silicon Revision 1.0 Version E =46ebruary 2011=E2=80=93Revised May 2011 p. 5357 Table 25-68. GPIO_CLEARWKUPENA "Caution: This register is kept for backward software compatibility. Us= e GPIO_IRQWAKEN_0 and GPIO_IRQWAKEN_1 instead." OMAP4430 TRM is similar. Todd