linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Raju, Sundaram" <sundaram@ti.com>
Cc: "Koul, Vinod" <vinod.koul@intel.com>,
	Dan <dan.j.williams@intel.com>,
	"davinci-linux-open-source@linux.davincidsp.com"
	<davinci-linux-open-source@linux.davincidsp.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC] dmaengine: add new api for preparing simple slave transfer
Date: Fri, 10 Jun 2011 11:43:18 +0100	[thread overview]
Message-ID: <20110610104318.GC24636@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E940301FE337F@dbde02.ent.ti.com>

On Fri, Jun 10, 2011 at 03:51:41PM +0530, Raju, Sundaram wrote:
> Consider a simple video use case of de-interlacing a video buffer.
> Odd lines have to be transferred first, and then the even lines are 
> transferred separately. This can be done by programming the 
> inter frame gap as the line size of the video buffer in the DMAC.
> This will require you to have only 2 descriptors, one for the
> odd lines and another for the even lines. This results in only
> 2 descriptors being written to DMAC registers.

How would this be handled with DMACs which can't 'skip' bytes in the
buffer?  You would have to generate a list of LLIs separately
describing each 'line' of video and chain them together.

How do you handle the situation where a driver uses your new proposed
API, but it doesn't support that in hardware.

> Actually we can deduce the chunk_size from the 
> dma_slave_config itself. It is either the src_addr_width or
> dst_addr_width based on the direction. Because at a stretch
> DMAC cannot transfer more than the slave register width.

I think you're misinterpreting those fields.  (dst|src)_addr_width tells
the DMA controller the width of each transaction - whether to issue a
byte, half-word, word or double-word read or write to the peripheral.
It doesn't say how many of those to issue, it just says what the
peripheral access size is to be.

In other words, they describe the width of the FIFO register.

  reply	other threads:[~2011-06-10 10:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09 12:39 [RFC] dmaengine: add new api for preparing simple slave transfer Raju, Sundaram
2011-06-09 12:47 ` Russell King - ARM Linux
2011-06-09 16:01   ` Raju, Sundaram
2011-06-09 16:32     ` Russell King - ARM Linux
2011-06-10  6:13       ` Koul, Vinod
2011-06-10 10:21         ` Raju, Sundaram
2011-06-10 10:43           ` Russell King - ARM Linux [this message]
2011-06-10 11:48             ` Raju, Sundaram
2011-06-10 13:33               ` Russell King - ARM Linux
2011-06-13 14:13                 ` Linus Walleij
2011-06-14  5:38                   ` Raju, Sundaram
2011-06-14  5:59                     ` Linus Walleij
2011-06-10  6:09     ` Koul, Vinod
2011-06-10 11:13       ` Raju, Sundaram
2011-06-10 16:47         ` Koul, Vinod
2011-06-14  6:42           ` Raju, Sundaram
2011-06-16  5:45             ` Koul, Vinod
2011-07-07 12:15               ` Raju, Sundaram
2011-07-07 19:37                 ` Linus Walleij
2011-06-09 18:58 ` Jassi Brar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110610104318.GC24636@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=dan.j.williams@intel.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sundaram@ti.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).