From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org, ti@lists.linaro.org,
linux-omap@vger.kernel.org, lrg@ti.com, sameo@linux.intel.com,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH] regulator: twl: Add 'fixed' set_voltage callback
Date: Fri, 24 Jun 2011 12:19:29 +0100 [thread overview]
Message-ID: <20110624111929.GC9483@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1308862014-11212-1-git-send-email-jaswinder.singh@linaro.org>
On Fri, Jun 24, 2011 at 02:16:54AM +0530, Jassi Brar wrote:
> Define dummy set_voltage callback for fixed lines,
> without which voltage constraints fail to apply.
>
> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
No, this isn't sensible - fixed voltage regulators aren't an unusual
property of this device, they've very common. The core should handle
this gracefully. Probably whatever consumer is doing the setting also
ought to be updated to check that the voltages it wants to set are
supported at startup since otherwise it can end up repeatedly trying to
set something that'll never work.
next prev parent reply other threads:[~2011-06-24 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 20:46 [PATCH] regulator: twl: Add 'fixed' set_voltage callback Jassi Brar
2011-06-24 11:19 ` Mark Brown [this message]
2011-06-24 13:06 ` Jaswinder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110624111929.GC9483@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jassisinghbrar@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=ti@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox