From: Todd Poynor <toddpoynor@google.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: paul@pwsan.com, rnayak@ti.com, santosh.shilimkar@ti.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 14/14] OMAP2+: clockdomain: Add an api to read idle mode
Date: Sun, 26 Jun 2011 10:51:41 -0700 [thread overview]
Message-ID: <20110626175141.GA2306@google.com> (raw)
In-Reply-To: <1308913560-333-15-git-send-email-b-cousson@ti.com>
On Fri, Jun 24, 2011 at 01:06:00PM +0200, Benoit Cousson wrote:
> From: Nayak, Rajendra <rnayak@ti.com>
>
> Add a clockdomain api to check if hardware supervised
> idle transitions are enabled on a clockdomain.
>
...
> + * clkdm_is_idle - Check if the clkdm hwsup/autoidle is enabled
> + * @clkdm: struct clockdomain *
> + *
> + * Returns true if the clockdomain is in hardware-supervised
> + * idle mode, or 0 otherwise.
> + *
> + */
> +int clkdm_is_idle(struct clockdomain *clkdm)
...
> void clkdm_allow_idle(struct clockdomain *clkdm);
> void clkdm_deny_idle(struct clockdomain *clkdm);
> +int clkdm_is_idle(struct clockdomain *clkdm);
Suggest the new API be named clkdm_allows_idle, since it tests that
hardware-supervised idle is allowed (perhaps via a call to
clkdm_allow_idle), and not that the clock domain is necessarily
idle at the time of call.
Todd
prev parent reply other threads:[~2011-06-26 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 11:06 [PATCH 14/14] OMAP2+: clockdomain: Add an api to read idle mode Benoit Cousson
2011-06-26 17:51 ` Todd Poynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110626175141.GA2306@google.com \
--to=toddpoynor@google.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox