linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 05/10] omap2+: Use dmtimer macros for clockevent
Date: Mon, 27 Jun 2011 00:39:24 -0700	[thread overview]
Message-ID: <20110627073923.GC23145@atomide.com> (raw)
In-Reply-To: <87r56ka341.fsf@ti.com>

* Kevin Hilman <khilman@ti.com> [110623 10:02]:
> Tony Lindgren <tony@atomide.com> writes:
> 
> > This patch makes timer-gp.c to use only a subset of dmtimer
> > functions without the need to initialize dmtimer code early.
> >
> > Also note that now with the inline functions, timer_set_next_event
> > becomes more efficient in the lines of assembly code.
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > Reviewed-by: Kevin Hilman <khilman@ti.com>
> 
> In order for this to work, *all* the dmtimer functions need to be
> converted.  Some still call the real driver, which may not yet be
> initialized (as pointed out for [7/10]...

Well omap_dm_timer_init_one is a static omap2plus specific
implementation that can then be then passed as a function pointer
to the dmtimer device driver in later patches.
 
> >  	gptimer = omap_dm_timer_request_specific(gptimer_id);
> 
> Here remains a call to the real driver, which is not yet initialized
> when called from sys_timer.init.

There's no need for omap_dm_timer_request_specific after the later
patches. It gets removed in the PM_DEBUG sysfs interface removal patch.

Tony

  reply	other threads:[~2011-06-27  7:39 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-20  9:23 [PATCH 00/10] init_early cleanup for omap init_irq and init_timer Tony Lindgren
2011-06-20  9:23 ` [PATCH 01/10] omap: Use separate init_irq functions to avoid cpu_is_omap tests early Tony Lindgren
2011-06-20  9:54   ` Russell King - ARM Linux
2011-06-20 10:14     ` Tony Lindgren
2011-06-27 17:08   ` Kevin Hilman
2011-06-20  9:23 ` [PATCH 02/10] omap: Set separate timer init functions to avoid cpu_is_omap tests Tony Lindgren
2011-06-20  9:23 ` [PATCH 03/10] omap: Move dmtimer defines to dmtimer.h Tony Lindgren
2011-06-20  9:56   ` Russell King - ARM Linux
2011-06-20 10:17     ` Tony Lindgren
2011-06-20  9:23 ` [PATCH 04/10] omap: Make a subset of dmtimer functions into inline functions Tony Lindgren
2011-06-20  9:23 ` [PATCH 05/10] omap2+: Use dmtimer macros for clockevent Tony Lindgren
2011-06-23 17:07   ` Kevin Hilman
2011-06-27  7:39     ` Tony Lindgren [this message]
2011-06-20  9:23 ` [PATCH 06/10] omap2+: Remove gptimer_wakeup for now Tony Lindgren
2011-06-20  9:39   ` Santosh Shilimkar
2011-06-20  9:48     ` Tony Lindgren
2011-06-23 15:05       ` Kevin Hilman
2011-06-23 15:13         ` Santosh Shilimkar
2011-06-27  8:08           ` Tony Lindgren
2011-06-27 16:30             ` Kevin Hilman
2011-06-27 18:16               ` Tony Lindgren
2011-06-27 17:32   ` Kevin Hilman
2011-06-27 19:19     ` Tony Lindgren
2011-06-27 21:16       ` Kevin Hilman
2011-06-20  9:23 ` [PATCH 07/10] omap2+: Reserve clocksource and timesource and initialize dmtimer later Tony Lindgren
2011-06-23 17:01   ` Kevin Hilman
2011-06-27  7:48     ` Tony Lindgren
2011-06-27 16:41       ` Kevin Hilman
2011-06-23 17:13   ` Kevin Hilman
2011-06-27  7:51     ` Tony Lindgren
2011-06-27 10:44       ` Tony Lindgren
2011-06-20  9:23 ` [PATCH 08/10] omap2+: Use dmtimer macros for clocksource Tony Lindgren
2011-06-23 15:28   ` Kevin Hilman
2011-06-23 16:47     ` Kevin Hilman
2011-06-23 17:10   ` Kevin Hilman
2011-06-27  7:54     ` Tony Lindgren
2011-06-27 10:48       ` Tony Lindgren
2011-06-27 16:41         ` Kevin Hilman
2011-06-20  9:23 ` [PATCH 09/10] omap2+: Remove omap2_gp_clockevent_set_gptimer Tony Lindgren
2011-06-20  9:23 ` [PATCH 10/10] omap2+: Rename timer-gp.c into timer.c to combine timer init functions Tony Lindgren
  -- strict thread matches above, loose matches on Subject: below --
2011-03-28 22:21 [PATCH 00/10] omap init_early changes for irq and timer init Tony Lindgren
2011-03-28 22:21 ` [PATCH 05/10] omap2+: Use dmtimer macros for clockevent Tony Lindgren
2011-03-29 17:16   ` Tony Lindgren
2011-03-31 21:35   ` Kevin Hilman
2011-03-31 22:04     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110627073923.GC23145@atomide.com \
    --to=tony@atomide.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).