[PATCH] Fix wrong OMAP_ES_x_y defines that make omap_rev_lt_x_y and friends misbehave

[PATCH] Fix wrong OMAP_ES_x_y defines that make omap_rev_lt_x_y and friends misbehave

[Tasslehoff Kjappfot]

From 620fa271b32f8bdd8f06954c0a2c96af6ed1dc7b Mon Sep 17 00:00:00 2001
From: Tasslehoff Kjappfot <tasskjapp@gmail.com>
Date: Tue, 14 Jun 2011 12:06:09 +0200
Subject: [PATCH] Fix wrong OMAP_ES_x_y defines that make
omap_rev_lt_x_y and friends misbehave
---
 arch/arm/plat-omap/include/plat/cpu.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/cpu.h
b/arch/arm/plat-omap/include/plat/cpu.h
index 7d24faa..ec63575 100644
--- a/arch/arm/plat-omap/include/plat/cpu.h
+++ b/arch/arm/plat-omap/include/plat/cpu.h
@@ -397,10 +397,10 @@ IS_OMAP_TYPE(3517, 0x3517)
  * Silicon revisions
  */
 #define OMAP_ES_1_0 0x00
-#define OMAP_ES_2_0 0x10
-#define OMAP_ES_2_1 0x20
-#define OMAP_ES_3_0 0x30
-#define OMAP_ES_3_1 0x40
+#define OMAP_ES_2_0 0x01
+#define OMAP_ES_2_1 0x02
+#define OMAP_ES_3_0 0x03
+#define OMAP_ES_3_1 0x04

 #define OMAP_REV_MASK 0x0000ff00
 #define OMAP_REV_BITS ((omap_rev() & OMAP_REV_MASK) >> 8)
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix wrong OMAP_ES_x_y defines that make omap_rev_lt_x_y and friends misbehave

[Tony Lindgren]

* Tasslehoff Kjappfot <tasskjapp@gmail.com> [110614 03:35]:
> From 620fa271b32f8bdd8f06954c0a2c96af6ed1dc7b Mon Sep 17 00:00:00 2001
> From: Tasslehoff Kjappfot <tasskjapp@gmail.com>
> Date: Tue, 14 Jun 2011 12:06:09 +0200
> Subject: [PATCH] Fix wrong OMAP_ES_x_y defines that make
> omap_rev_lt_x_y and friends misbehave

Hmm, we don't seem to have these in the mainline kernel?
Maybe take a look if something still needs to patched
there?

Tony

> ---
>  arch/arm/plat-omap/include/plat/cpu.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> diff --git a/arch/arm/plat-omap/include/plat/cpu.h
> b/arch/arm/plat-omap/include/plat/cpu.h
> index 7d24faa..ec63575 100644
> --- a/arch/arm/plat-omap/include/plat/cpu.h
> +++ b/arch/arm/plat-omap/include/plat/cpu.h
> @@ -397,10 +397,10 @@ IS_OMAP_TYPE(3517, 0x3517)
>   * Silicon revisions
>   */
>  #define OMAP_ES_1_0 0x00
> -#define OMAP_ES_2_0 0x10
> -#define OMAP_ES_2_1 0x20
> -#define OMAP_ES_3_0 0x30
> -#define OMAP_ES_3_1 0x40
> +#define OMAP_ES_2_0 0x01
> +#define OMAP_ES_2_1 0x02
> +#define OMAP_ES_3_0 0x03
> +#define OMAP_ES_3_1 0x04
> 
>  #define OMAP_REV_MASK 0x0000ff00
>  #define OMAP_REV_BITS ((omap_rev() & OMAP_REV_MASK) >> 8)
> --
> 1.7.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] Fix wrong OMAP_ES_x_y defines that make omap_rev_lt_x_y and friends misbehave

[Premi, Sanjeev]

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org 
> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Tony Lindgren
> Sent: Tuesday, June 14, 2011 5:11 PM
> To: Tasslehoff Kjappfot
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH] Fix wrong OMAP_ES_x_y defines that make 
> omap_rev_lt_x_y and friends misbehave
> 
> * Tasslehoff Kjappfot <tasskjapp@gmail.com> [110614 03:35]:
> > From 620fa271b32f8bdd8f06954c0a2c96af6ed1dc7b Mon Sep 17 
> 00:00:00 2001
> > From: Tasslehoff Kjappfot <tasskjapp@gmail.com>
> > Date: Tue, 14 Jun 2011 12:06:09 +0200
> > Subject: [PATCH] Fix wrong OMAP_ES_x_y defines that make
> > omap_rev_lt_x_y and friends misbehave
> 
> Hmm, we don't seem to have these in the mainline kernel?
> Maybe take a look if something still needs to patched
> there?

[sp] Yes. these don't apply on mainline.
     I believe the kernel is using this patch I submitted [1],
     (or derived from it), but missing [2].

Tony,
  Now that there are multiple processors with their own
  revisions, do you believe an update version of [1]
  patch would be useful?

  [1] http://marc.info/?l=linux-omap&m=127972517400499&w=2
  [2] http://marc.info/?l=linux-omap&m=128597605524824&w=2
 
~sanjeev

> 
> Tony
> 

Re: [PATCH] Fix wrong OMAP_ES_x_y defines that make omap_rev_lt_x_y and friends misbehave

[Tony Lindgren]

* Premi, Sanjeev <premi@ti.com> [110616 06:22]:
> > 
> > Hmm, we don't seem to have these in the mainline kernel?
> > Maybe take a look if something still needs to patched
> > there?
> 
> [sp] Yes. these don't apply on mainline.
>      I believe the kernel is using this patch I submitted [1],
>      (or derived from it), but missing [2].
> 
> Tony,
>   Now that there are multiple processors with their own
>   revisions, do you believe an update version of [1]
>   patch would be useful?

Yes please take a look and see if we still need to patch
something in the mainline kernel for this.

Regards,

Tony
 
>   [1] http://marc.info/?l=linux-omap&m=127972517400499&w=2
>   [2] http://marc.info/?l=linux-omap&m=128597605524824&w=2