From: Tony Lindgren <tony@atomide.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, khilman@ti.com,
b-cousson@ti.com, Nishanth Menon <nm@ti.com>,
Moiz Sonasath <m-sonasath@ti.com>
Subject: Re: [PATCH 7/7] 4460sdp/blaze/panda: hwmod: Prevent gpio1 reset during hwmod init
Date: Thu, 30 Jun 2011 23:32:41 -0700 [thread overview]
Message-ID: <20110701063241.GX23145@atomide.com> (raw)
In-Reply-To: <1309486081-8257-8-git-send-email-rnayak@ti.com>
* Rajendra Nayak <rnayak@ti.com> [110630 19:03]:
> For 4460sdp/blaze/panda, GPIO-7 of bank1 is used for controlling
> the TPS modes, hence GPIO1 should not be reset
> during init as reset will cause the TPS voltage to
> drop to 0.9 V preventing the system from continuing the boot.
NAK for this patch. We don't want any of this in init_early.
The problem is with hwmod core code that wrongly assumes it
can just reset all devices.
We should fix the hwmod code to lazily only reset devices as they
are enabled, and only reset unused devices with late_initcall
when we have decent debug output. And the reset of unused devices
should be possible to turn off with some kernel cmdline option.
Regards,
Tony
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -36,6 +36,7 @@
> #include <plat/usb.h>
> #include <plat/mmc.h>
> #include <plat/omap4-keypad.h>
> +#include <plat/omap_hwmod.h>
> #include <video/omapdss.h>
>
> #include "mux.h"
> @@ -298,6 +299,19 @@ static void __init omap_4430sdp_init_early(void)
> #ifdef CONFIG_OMAP_32K_TIMER
> omap2_gp_clockevent_set_gptimer(1);
> #endif
> + /*
> + * For 4460sdp/blaze, GPIO-7 of bank1 is used for controlling
> + * the TPS modes, hence GPIO1 should not be reset
> + * during init as reset will cause the TPS voltage to
> + * drop to 0.9 V preventing the system from continuing the boot.
> + */
> + if (cpu_is_omap446x()) {
> + struct omap_hwmod *gpio1 = omap_hwmod_lookup("gpio1");
> + if (gpio1)
> + omap_hwmod_no_setup_reset(gpio1);
> + else
> + pr_err("%s: gpio1 hwmod lookup failed\n", __func__);
> + }
> }
>
> static struct omap_musb_board_data musb_board_data = {
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index 0cfe200..75a847c 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -40,6 +40,7 @@
> #include <plat/common.h>
> #include <plat/usb.h>
> #include <plat/mmc.h>
> +#include <plat/omap_hwmod.h>
> #include <video/omap-panel-generic-dpi.h>
> #include "timer-gp.h"
>
> @@ -100,6 +101,19 @@ static void __init omap4_panda_init_early(void)
> {
> omap2_init_common_infrastructure();
> omap2_init_common_devices(NULL, NULL);
> + /*
> + * For 4460panda, GPIO-7 of bank1 is used for controling
> + * the TPS modes, hence GPIO1 should not be reset
> + * during init as reset will cause the TPS voltage to
> + * drop to 0.9 V preventing the system from continuing the boot.
> + */
> + if (cpu_is_omap446x()) {
> + struct omap_hwmod *gpio1 = omap_hwmod_lookup("gpio1");
> + if (gpio1)
> + omap_hwmod_no_setup_reset(gpio1);
> + else
> + pr_err("%s: gpio1 hwmod lookup failed\n", __func__);
> + }
> }
>
> static const struct usbhs_omap_board_data usbhs_bdata __initconst = {
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-01 6:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 2:07 [PATCH 0/7] OMAP4: Add 4460 base support Rajendra Nayak
2011-07-01 2:07 ` [PATCH 1/7] OMAP: ID: introduce chip detection for OMAP4460 Rajendra Nayak
2011-07-01 2:07 ` [PATCH 2/7] OMAP4: ID: add omap_has_feature for max freq supported Rajendra Nayak
2011-07-01 2:07 ` [PATCH 3/7] OMAP4: PRCM: OMAP4460 specific PRM and CM register bitshifts Rajendra Nayak
2011-07-01 2:07 ` [PATCH 4/7] OMAP4: clocks: Update the clock tree with 4460 clock nodes Rajendra Nayak
2011-07-01 2:07 ` [PATCH 5/7] OMAP4: powerdomain: Reuse on 4460 using CHIP_IS_44XX Rajendra Nayak
2011-07-01 2:08 ` [PATCH 6/7] OMAP4: clockdomain: " Rajendra Nayak
2011-07-01 2:08 ` [PATCH 7/7] 4460sdp/blaze/panda: hwmod: Prevent gpio1 reset during hwmod init Rajendra Nayak
2011-07-01 6:32 ` Tony Lindgren [this message]
2011-07-03 4:14 ` Paul Walmsley
2011-07-04 8:53 ` Tony Lindgren
2011-07-05 7:40 ` Paul Walmsley
2011-07-05 10:45 ` Tony Lindgren
2011-07-05 21:47 ` Paul Walmsley
2011-07-06 6:47 ` Tony Lindgren
2011-07-01 2:41 ` [PATCH 2/7] OMAP4: ID: add omap_has_feature for max freq supported Todd Poynor
2011-07-01 4:48 ` Aneesh V
2011-07-01 6:25 ` [PATCH 1/7] OMAP: ID: introduce chip detection for OMAP4460 Tony Lindgren
2011-07-01 10:15 ` Aneesh V
2011-07-01 16:31 ` [PATCH 0/7] OMAP4: Add 4460 base support Kevin Hilman
2011-07-01 16:36 ` Kevin Hilman
2011-07-01 16:40 ` Kevin Hilman
2011-07-01 17:00 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701063241.GX23145@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=m-sonasath@ti.com \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox