public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Kevin Hilman <khilman@ti.com>
Cc: linux-pm@lists.linux-foundation.org,
	Alan Stern <stern@rowland.harvard.edu>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [linux-pm] runtime PM usage_count during driver_probe_device()?
Date: Fri, 1 Jul 2011 22:53:19 +0200	[thread overview]
Message-ID: <201107012253.19988.rjw@sisk.pl> (raw)
In-Reply-To: <87pqlu3sy3.fsf@ti.com>

Hi,

On Friday, July 01, 2011, Kevin Hilman wrote:
> Alan Stern <stern@rowland.harvard.edu> writes:
> 
> > On Fri, 1 Jul 2011, Kevin Hilman wrote:
> >
> >> OK, so the ->probe() part has been explained and makes sense, but I
> >> would expect ->remove() to be similarily protected (as the documentation
> >> states.)  But that is not the case.  Is that a bug?  If so, patch below
> >> makes the code match the documentation.
> >
> > I suspect it is a bug, but it's hard to be sure.  It's so _blatantly_ 
> > wrong that it looks like it was done deliberately.
> 
> heh

I seem to remeber having a problem with the pm_runtime_put_sync() after
drv->remove(dev) ...

So the code in question was introduced by

commit e1866b33b1e89f077b7132daae3dfd9a594e9a1a
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date:   Fri Apr 29 00:33:45 2011 +0200

    PM / Runtime: Rework runtime PM handling during driver removal

with a long changelog explaining the reason why.  Which seems to make sense. ;-)

So I'm not sure.

Thanks,
Rafael

  parent reply	other threads:[~2011-07-01 20:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 22:19 runtime PM usage_count during driver_probe_device()? Kevin Hilman
2011-07-01  0:09 ` Kevin Hilman
2011-07-01  0:33   ` [linux-pm] " Rafael J. Wysocki
2011-07-01  5:57     ` Ohad Ben-Cohen
2011-07-01 14:46       ` Kevin Hilman
2011-07-01 11:32     ` Ming Lei
2011-07-01 14:54   ` Alan Stern
2011-07-01 14:43 ` Alan Stern
2011-07-01 14:44 ` Kevin Hilman
2011-07-01 15:25   ` [linux-pm] " Alan Stern
2011-07-01 15:45     ` Kevin Hilman
2011-07-01 15:59       ` Alan Stern
2011-07-01 16:54         ` Kevin Hilman
2011-07-01 20:53       ` Rafael J. Wysocki [this message]
2011-07-01 21:12         ` Alan Stern
2011-07-01 21:44           ` Rafael J. Wysocki
2011-07-01 22:12           ` [PATCH] PM / Runtime: Update documentation regarding driver removal Rafael J. Wysocki
2011-07-01 22:49             ` Kevin Hilman
2011-07-01 21:42 ` [linux-pm] runtime PM usage_count during driver_probe_device()? Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201107012253.19988.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox