Re: [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board

Grant Likely
2011-07-06T18:49:54Z

On Thu, Jun 30, 2011 at 07:27:02AM -0700, Tony Lindgren wrote:
> Hi,
>
> Few comments on the .dts data layout below.
>
> * G, Manjunath Kondaiah <manjugk@ti.com> [110630 02:44]:
> > --- a/arch/arm/boot/dts/omap3-beagle-nunchuck.dts
> > +++ b/arch/arm/boot/dts/omap3-beagle-nunchuck.dts
> > @@ -2,11 +2,6 @@
> >
> > / {
> > i2c@48072000 {
> > - compatible = "ti,omap3-i2c";
> > - reg = <0x48072000 0x80>;
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> > -
> > eeprom@50 {
> > compatible = "at,at24c01";
> > reg = < 0x50 >;
>
> The board .dts file should include the omap3 SoC .dts file.
>
> The omap3 SoC .dts file should have the devices mapped to L3 and L4
> busses, and the then i2c@1 would just contain the bus offset.
>
> Then the i2c@1 entry would be repeated in the board specific
> .dts and tell that the i2c@1 is enabled.

yup.