From: Felipe Balbi <balbi@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Felipe Balbi <balbi@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
khilman@ti.com, b-cousson@ti.com, Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH] OMAP: powerdomains: Make all powerdomain target states as ON at init
Date: Fri, 15 Jul 2011 11:37:54 +0300 [thread overview]
Message-ID: <20110715083753.GG2611@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1107150222400.16606@utopia.booyaka.com>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
Hi,
On Fri, Jul 15, 2011 at 02:23:16AM -0600, Paul Walmsley wrote:
> Hi Felipe,
>
> On Fri, 15 Jul 2011, Felipe Balbi wrote:
>
> > I see... thanks for clarifying. The comment above the code wasn't really
> > clear about it to me.
>
> No worries. If you propose a clarification, I'll stick that into the
> patch.
How about something like:
/*
* Program target state of all power domains to ON. This is to prevent
* power domains from hitting low power states during boot up and
* potentially causing accesses to the address space of an IP while it
* is disabled.
*
* PM late init code will make sure of disabling all unused IPs later.
*/
not sure if it's a lot better though.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-07-15 8:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 3:26 [PATCH] OMAP: powerdomains: Make all powerdomain target states as ON at init Santosh Shilimkar
2011-07-13 3:26 ` [PATCH] OMAP: clockdomain: Wait for powerdomain to be ON when using clockdomain force wakeup Santosh Shilimkar
2011-07-15 8:03 ` Paul Walmsley
2011-07-16 7:48 ` Santosh Shilimkar
2011-08-11 14:07 ` Santosh
2011-08-12 14:27 ` Paul Walmsley
2011-08-17 1:47 ` Paul Walmsley
2011-08-17 5:11 ` Santosh
2011-07-15 7:54 ` [PATCH] OMAP: powerdomains: Make all powerdomain target states as ON at init Paul Walmsley
2011-07-16 7:28 ` Santosh Shilimkar
2011-08-17 1:50 ` Paul Walmsley
2011-07-15 8:03 ` Felipe Balbi
2011-07-15 8:10 ` Paul Walmsley
2011-07-15 8:17 ` Felipe Balbi
2011-07-15 8:23 ` Paul Walmsley
2011-07-15 8:37 ` Felipe Balbi [this message]
2011-08-17 1:56 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715083753.GG2611@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox