From: Tony Lindgren <tony@atomide.com>
To: Jan Weitzel <j.weitzel@phytec.de>
Cc: linux-omap@vger.kernel.org
Subject: Re: [RFC 1/2] omap4: board-omap4panda: prepare for join
Date: Thu, 21 Jul 2011 00:25:15 -0700 [thread overview]
Message-ID: <20110721072515.GC5783@atomide.com> (raw)
In-Reply-To: <1311075927-5562-2-git-send-email-j.weitzel@phytec.de>
* Jan Weitzel <j.weitzel@phytec.de> [110719 04:40]:
> Prepare board-omap4panda for joing other similar boards.
> Split common stuff into board-omap4panda-common.
>
> MUX: board_mux and omap4_panda_mux
> omap4_common_preinit: for muxing
> omap4_common_init: all common devices
> struct panda_board_data: gpios, omap_board_data, i2c_board_info ...
>
> some inititialisation check if omap4_panda_config entry is valid
> i2c_2_board_speed == 0 -> i2c_2 not used
> hup_power_gpio == -EINVAL -> gpio not used
This should probably be split into two patches:
- Prepare things for panda common code
- Move panda common code
That way we can see from the patches what actually
changes. Might also make sense to do it the other way
around for the two patches.
Regards,
Tony
next prev parent reply other threads:[~2011-07-21 7:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 10:04 [PATCH 0/3] ARM:OMAP4 add Phytec phyCORE-OMAP4 board Jan Weitzel
2011-07-08 10:04 ` [PATCH 1/3] ARM: OMAP4: Add pcm049 to Kconfig/Makefile Jan Weitzel
2011-07-08 11:49 ` Sergei Shtylyov
2011-07-08 11:55 ` Tony Lindgren
2011-07-08 11:58 ` Felipe Balbi
2011-07-14 7:27 ` Tony Lindgren
2011-07-14 7:47 ` Tony Lindgren
2011-07-08 12:21 ` [PATCH v2] ARM:OMAP4 add Phytec phyCORE-OMAP4 board Jan Weitzel
2011-07-13 8:03 ` Tony Lindgren
2011-07-13 10:58 ` Jan Weitzel
2011-07-13 10:59 ` [PATCH] ARM: OMAP4: PCM049: remove vusim regulator Jan Weitzel
2011-07-13 12:13 ` Sergei Shtylyov
2011-07-13 12:54 ` [PATCH v2] " Jan Weitzel
2011-07-13 12:56 ` [PATCH] " Jan Weitzel
2011-07-14 7:34 ` Tony Lindgren
2011-07-14 8:39 ` Jan Weitzel
2011-07-15 7:50 ` Tony Lindgren
2011-07-15 7:58 ` Felipe Balbi
2011-07-15 8:20 ` Tony Lindgren
2011-07-15 8:31 ` Felipe Balbi
2011-07-15 10:59 ` Tony Lindgren
2011-07-15 9:47 ` Jan Weitzel
2011-07-15 10:55 ` Tony Lindgren
2011-07-15 16:06 ` [RFC 0/2] join omap4panda and pcm049 Jan Weitzel
2011-07-18 8:42 ` Tony Lindgren
2011-07-19 11:45 ` [RFC 0/2 v2] " Jan Weitzel
2011-07-19 11:45 ` [RFC 1/2] omap4: board-omap4panda: prepare for join Jan Weitzel
2011-07-21 7:25 ` Tony Lindgren [this message]
2011-07-19 11:45 ` [RFC 2/2] omap4: board-omap4pcm049: add Phytec phyCORE-OMAP4 Jan Weitzel
2011-07-21 7:38 ` Tony Lindgren
2011-07-15 16:06 ` [PATCH 1/2] omap4: board-omap4panda: prepare for join Jan Weitzel
2011-07-15 16:06 ` [PATCH 2/2] omap4: board-omap4panda: join Phytec phyCORE-OMAP4 Jan Weitzel
2011-07-08 10:04 ` [PATCH 2/3] ARM: OMAP4: add pcm049 DEBUGLL Jan Weitzel
2011-07-08 10:04 ` [PATCH 3/3] ARM: OMAP4: platformcode board-omap4pcm049.c Jan Weitzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110721072515.GC5783@atomide.com \
--to=tony@atomide.com \
--cc=j.weitzel@phytec.de \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).