omap_device prints

omap_device prints

[Russell King - ARM Linux]

I spotted this while booting the OMAP4430 SDP:

omap_device: omap4-keypad.-1: new worst case activate latency 0: 61035

and found that it came from here:

        pr_debug("omap_device: %s: activating\n", od->pdev.name);

                pr_debug("omap_device: %s: pm_lat %d: activate: elapsed time "
                         "%llu nsec\n", od->pdev.name, od->pm_lat_level,
                         act_lat);

                                pr_warning("omap_device: %s.%d: new worst case "
                                           "activate latency %d: %llu\n",
                                           od->pdev.name, od->pdev.id,
                                           od->pm_lat_level, act_lat);
                                pr_warning("omap_device: %s.%d: activate "
                                           "latency %d higher than exptected. "
                                           "(%llu > %d)\n",
                                           od->pdev.name, od->pdev.id,
                                           od->pm_lat_level, act_lat,
                                           odpl->activate_lat);

Is there something wrong with dev_name(&od->pdev.dev) so that we have
consistent naming of devices, rather than poking about inside the
platform_device accessing the name initializers directly ?

Re: omap_device prints

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]

On Thu, Jul 21, 2011 at 10:51:09AM +0100, Russell King - ARM Linux wrote:
> I spotted this while booting the OMAP4430 SDP:
> 
> omap_device: omap4-keypad.-1: new worst case activate latency 0: 61035
> 
> and found that it came from here:
> 
>         pr_debug("omap_device: %s: activating\n", od->pdev.name);
> 
>                 pr_debug("omap_device: %s: pm_lat %d: activate: elapsed time "
>                          "%llu nsec\n", od->pdev.name, od->pm_lat_level,
>                          act_lat);
> 
>                                 pr_warning("omap_device: %s.%d: new worst case "
>                                            "activate latency %d: %llu\n",
>                                            od->pdev.name, od->pdev.id,
>                                            od->pm_lat_level, act_lat);
>                                 pr_warning("omap_device: %s.%d: activate "
>                                            "latency %d higher than exptected. "
>                                            "(%llu > %d)\n",
>                                            od->pdev.name, od->pdev.id,
>                                            od->pm_lat_level, act_lat,
>                                            odpl->activate_lat);
> 
> Is there something wrong with dev_name(&od->pdev.dev) so that we have
> consistent naming of devices, rather than poking about inside the
> platform_device accessing the name initializers directly ?

or dev_*() macros, instead ?

dev_dbg(&od->pdev.dev, "activating\n");

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

Re: omap_device prints

[Kevin Hilman]

Russell King - ARM Linux <linux@arm.linux.org.uk> writes:

> I spotted this while booting the OMAP4430 SDP:
>
> omap_device: omap4-keypad.-1: new worst case activate latency 0: 61035
>

[...]

> Is there something wrong with dev_name(&od->pdev.dev) so that we have
> consistent naming of devices, rather than poking about inside the
> platform_device accessing the name initializers directly ?

I've been meaning to convert most of these from pr_debug() to dev_dbg().

There are a few that have to remain pr_debug() because they are used
before the platform_device (and struct device) are initialized, but most
of them can be converted.

Patch coming shortly.

Kevin