Re: Kconfig help descriptions

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 2075 bytes --]

Hi,

On Thu, Jul 21, 2011 at 10:22:21AM +0100, Russell King - ARM Linux wrote:
> Some of the Kconfig help descriptions aren't very useful - for example:
> 
> | CONFIG_TWL4030_MADC:
> | 
> | This driver provides support for triton TWL4030-MADC. The
> | driver supports both RT and SW conversion methods.
> | 
> | This driver can be built as a module. If so it will be
> | named twl4030-madc
> 
> What is madc?  What does it do?  Do I enable it for the OMAP 4430SDP ?

the problem seems to be worse then you thought:

$ git ls-files drivers/  | grep madc
drivers/hwmon/twl4030-madc-hwmon.c
drivers/mfd/twl4030-madc.c

Both from the same author:

$ git grep -e MODULE_AUTHOR drivers/mfd/twl4030-madc.c drivers/hwmon/twl4030-madc-hwmon.c
drivers/hwmon/twl4030-madc-hwmon.c:MODULE_AUTHOR("J Keerthy");
drivers/mfd/twl4030-madc.c:MODULE_AUTHOR("J Keerthy");

but added on different commits:

commit f99c1d4f94f91fd3a20bd2eaa3be9c5e7d2668eb
Author: Keerthy <j-keerthy@ti.com>
Date:   Tue Mar 1 19:12:26 2011 +0530

    mfd: Add twl4030 madc driver
    
    Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring
    ADC. This driver monitors the real time conversion of analog signals like
    battery temperature, battery cuurent etc.
    
    Signed-off-by: Keerthy <j-keerthy@ti.com>
    Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

commit 0070bddfe7275e5bc763884a8ac59651f4e79eab
Author: Keerthy <j-keerthy@ti.com>
Date:   Tue Mar 1 19:12:36 2011 +0530

    hwmon: twl4030: Hwmon Driver for TWL4030 MADC
    
    This driver exposes the sysfs nodes of the TWL4030 MADC module.
    All the voltage channel values are expressed in terms of mV. Channel 13
    and channel 14 are reserved. There are channels which represent
    temperature and current the output is represented by celcius
    and mA respectively.
    
    Signed-off-by: Keerthy <j-keerthy@ti.com>
    Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
    Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>


-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]