[PATCH] OMAP: irq: loop counter fix in omap_init_irq()

[PATCH] OMAP: irq: loop counter fix in omap_init_irq()

[Tapani Utriainen]

From: Tapani Utriainen <tapani@technexion.com>

Fixes bug where variable i was redundantly used for counting two nested loops.

Signed-off-by: Tapani Utriainen <tapani@technexion.com>
--- 
 irq.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/arch/arm/mach-omap2/irq.c
+++ b/arch/arm/mach-omap2/irq.c
@@ -165,8 +165,8 @@ static void __init omap_init_irq(u32 base, int nr_irqs)
 
 		omap_irq_bank_init_one(bank);
 
-		for (i = 0, j = 0; i < bank->nr_irqs; i += 32, j += 0x20)
-			omap_alloc_gc(bank->base_reg + j, i, 32);
+		for (j = 0; j < bank->nr_irqs; j += 32)
+			omap_alloc_gc(bank->base_reg + j, j, 32);
 
 		nr_of_irqs += bank->nr_irqs;
 		nr_banks++;

Re: [PATCH] OMAP: irq: loop counter fix in omap_init_irq()

[Tony Lindgren]

* Tapani Utriainen <tapani@technexion.com> [110721 20:58]:
> From: Tapani Utriainen <tapani@technexion.com>
> 
> Fixes bug where variable i was redundantly used for counting two nested loops.

Thanks & sorry for the delay. Adding this into fixes.

Tony
 
> Signed-off-by: Tapani Utriainen <tapani@technexion.com>
> --- 
>  irq.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/arch/arm/mach-omap2/irq.c
> +++ b/arch/arm/mach-omap2/irq.c
> @@ -165,8 +165,8 @@ static void __init omap_init_irq(u32 base, int nr_irqs)
>  
>  		omap_irq_bank_init_one(bank);
>  
> -		for (i = 0, j = 0; i < bank->nr_irqs; i += 32, j += 0x20)
> -			omap_alloc_gc(bank->base_reg + j, i, 32);
> +		for (j = 0; j < bank->nr_irqs; j += 32)
> +			omap_alloc_gc(bank->base_reg + j, j, 32);
>  
>  		nr_of_irqs += bank->nr_irqs;
>  		nr_banks++;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html