Re: [PATCH V3 03/19] OMAP3+: voltage: remove initial voltage

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 2382 bytes --]

On Tue, Mar 08, 2011 at 07:22:32AM +0530, Nishanth Menon wrote:
> On Mon, Mar 07, 2011 at 07:23:15PM +0300, Sergei Shtylyov wrote:
> > Hello.
> > 
> > On 07-03-2011 5:52, Nishanth Menon wrote:
> > 
> > >>>Blindly setting a 1.2V setting
> > 
> > >>Hm, seems tautological...
> > 
> > >As a non native English speaker, I would like to understand how we could
> > >improve this. I suppose you mean "Blindly setting 1.2V" is better here. Am i
> > >correct?
> > 
> >    Yes.
> OK, here is the update as per the suggestion:
> Regards,
> Nishanth Menon
> From: Nishanth Menon <nm@ti.com>
> Date: Tue, 15 Feb 2011 09:37:18 +0530
> Subject: [PATCH V4 3/19] OMAP3+: voltage: remove initial voltage
> 
> Blindly setting 1.2V in the initial structure may not even match the
> default voltages stored in the voltage table which are supported for
> the domain. For example, OMAP3430 core domain does not use 1.2V and
> ends up generating a warning on the first transition.
> 
> Further, since omap2_set_init_voltage is called as part of the pm
> framework's initialization sequence to configure the voltage required
> for the current OPP, the call does(and has to) setup the system
> voltage(curr_volt as a result) using the right mechanisms appropriate
> for the system at that point of time. This also overrides
> initialization we are currently doing in voltage.c making it
> redundant. So, remove the wrong and redundant initialization.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

FWIW:

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
>  arch/arm/mach-omap2/voltage.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c
> index 56961df..1b40aa0 100644
> --- a/arch/arm/mach-omap2/voltage.c
> +++ b/arch/arm/mach-omap2/voltage.c
> @@ -116,7 +116,6 @@ static int __init _config_common_vdd_data(struct omap_vdd_info *vdd)
>  	sys_clk_speed /= 1000;
>  
>  	/* Generic voltage parameters */
> -	vdd->curr_volt = 1200000;
>  	vdd->volt_scale = vp_forceupdate_scale_voltage;
>  	vdd->vp_enabled = false;
>  
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]