From: Felipe Balbi <balbi@ti.com>
To: "Pandita, Vikram" <vikram.pandita@ti.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Anand Gadiyar <gadiyar@ti.com>, "Balbi, Felipe" <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Moiz Sonasath <m-sonasath@ti.com>
Subject: Re: [PATCH v4] usb: musb: Enable DMA mode1 RX for USB-Mass-Storage
Date: Tue, 26 Jul 2011 18:06:57 +0300 [thread overview]
Message-ID: <20110726150655.GK32582@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <CAFm5wm2ng-fs0OgUG+h1JaF3_LBp93fHw2Vap2oD_j7Ok0NNnw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
Hi,
On Wed, Jul 20, 2011 at 09:48:53AM -0700, Pandita, Vikram wrote:
> > This *today happens to be only UMS* is my exact point here.
> > Can you guarantee no other function driver will ever expect only
> > full packet xfers and treat short as errors ?
> >
>
> We are trying to test if short_not_ok may not be needed at all. But
> all gadgets need to be tested on MUSB for that.
> We will need wider help from MUSB maintainer/author(anand g) to
> determine if removing short_not_ok is fine on MUSB for _all_ gadgets.
>
> To be safe we only enable for UMS use case today that is definitely
> working fine.
>
> Time for Maintainer/author to pitch in !!
I'm thinking on allowing this patch to go in if nobody has really strong
arguments against it. The real fix, though, would need a bigger re-write
of the endpoint IRQ handling and that would need more time to write and
stabilize. Together with the huge amount of HW issues MUSB has, it's
quite a task (been there, done that).
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-07-26 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 5:11 [PATCH v4] usb: musb: Enable DMA mode1 RX for USB-Mass-Storage Vikram Pandita
2011-07-20 5:34 ` Jassi Brar
2011-07-20 5:45 ` Pandita, Vikram
2011-07-20 5:53 ` Jassi Brar
2011-07-20 16:48 ` Pandita, Vikram
2011-07-26 15:06 ` Felipe Balbi [this message]
[not found] ` <20110726150655.GK32582-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-07-27 3:50 ` Jassi Brar
2011-07-27 11:30 ` Felipe Balbi
2011-07-29 4:45 ` Felipe Balbi
2011-07-29 4:50 ` Pandita, Vikram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726150655.GK32582@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=gadiyar@ti.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m-sonasath@ti.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).