From: Samuel Ortiz <sameo@linux.intel.com>
To: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, balbi@ti.com, gadiyar@ti.com,
parthab@india.ti.com, kishon@ti.com
Subject: Re: [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()
Date: Wed, 27 Jul 2011 11:53:28 +0200 [thread overview]
Message-ID: <20110727095328.GC26275@sortiz-mobl> (raw)
In-Reply-To: <1311340170-28773-1-git-send-email-keshava_mgowda@ti.com>
Hi Keshava,
On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote:
> From: Keshava Munegowda <Keshava_mgowda@ti.com>
>
> usbhs_disable function was invoking clk_enable() instead of
> clk_disable(), thus only increasing the clock usage counter and
> preventing this particular clock from being ever turned off.
> Because of this, the power domain of omap4 the USB Host subsystem
> would never reach lower power states.This patch calls clk_disable()
> in usbhs_disable function
I applied this patch now, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-07-27 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 13:09 [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable() Keshava Munegowda
[not found] ` <1311340170-28773-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2011-07-26 14:34 ` Felipe Balbi
2011-07-27 9:53 ` Samuel Ortiz [this message]
2011-07-27 11:15 ` Munegowda, Keshava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727095328.GC26275@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=balbi@ti.com \
--cc=gadiyar@ti.com \
--cc=keshava_mgowda@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=parthab@india.ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).