From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Daniel Morsing <daniel.morsing@gmail.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: Build failure: bisected: v3.1-rc1 with config ARCH_OMAP && !ARCH_OMAP4 fails with linker error
Date: Tue, 9 Aug 2011 06:14:53 -0700 [thread overview]
Message-ID: <20110809131453.GR1866@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1108081435340.4764@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [110808 13:31]:
> Hi
>
> On Mon, 8 Aug 2011, Daniel Morsing wrote:
>
> > Building the v3.1-rc1 kernel with ARCH_OMAP && !ARCH_OMAP4 support fails
> > on linking with the following error
> >
> > ...
> > LD .tmp_vmlinux1
> > arch/arm/mach-omap2/built-in.o:(.data+0xf7d8): undefined reference to `omap4430_phy_init'
> > arch/arm/mach-omap2/built-in.o:(.data+0xf7dc): undefined reference to `omap4430_phy_exit'
> > arch/arm/mach-omap2/built-in.o:(.data+0xf7e0): undefined reference to `omap4430_phy_power'
> > arch/arm/mach-omap2/built-in.o:(.data+0xf7e4): undefined reference to `omap4430_phy_set_clk'
> > arch/arm/mach-omap2/built-in.o:(.data+0xf7e8): undefined reference to `omap4430_phy_suspend'
> >
> > I've bisected the first bad commit to "OMAP4: Move common twl6030
> > configuration to twl-common" (commit-id
> > b22f954bae35be115a10c6426dc070f7d652b32e). The problem seems to be
> > unconditionally taking a function pointer to an omap4430 specific
> > function in arch/arm/mach-omap2/twl-common.c. The definition for
> > omap4430_phy_init and friends is in
> > arch/arm/mach-omap2/omap_phy_internal.c, which is only compiled when
> > building with support for one of the omap4430 boards.
>
> Thanks for the bisect; this should be fixed by
>
> https://patchwork.kernel.org/patch/963462/
Hmm, there are also these when CONFIG_ARCH_OMAP4 is not selected:
arch/arm/mach-omap2/built-in.o: In function `_enable_module':
arch/arm/mach-omap2/omap_hwmod.c:701: undefined reference to `omap4_cminst_module_enable'
arch/arm/mach-omap2/built-in.o: In function `_disable_module':
arch/arm/mach-omap2/omap_hwmod.c:726: undefined reference to `omap4_cminst_module_disable'
arch/arm/mach-omap2/built-in.o: In function `_wait_target_disable':
arch/arm/mach-omap2/omap_hwmod.c:1179: undefined reference to `omap4_cminst_wait_module_idle'
distcc[27594] ERROR: compile (null) on localhost failed
make: *** [.tmp_vmlinux1] Error 1
Care to take a look?
Tony
next prev parent reply other threads:[~2011-08-09 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 16:08 Build failure: bisected: v3.1-rc1 with config ARCH_OMAP && !ARCH_OMAP4 fails with linker error Daniel Morsing
2011-08-08 20:36 ` Paul Walmsley
2011-08-09 13:14 ` Tony Lindgren [this message]
2011-08-09 13:21 ` Péter Ujfalusi
2011-08-09 13:39 ` Tony Lindgren
2011-08-10 3:07 ` Paul Walmsley
2011-08-10 6:57 ` Paul Walmsley
2011-08-10 9:21 ` Tony Lindgren
2011-08-10 9:34 ` Paul Walmsley
2011-08-10 8:37 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110809131453.GR1866@atomide.com \
--to=tony@atomide.com \
--cc=daniel.morsing@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox