From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Keerthy <j-keerthy@ti.com>,
lm-sensors@lm-sensors.org, vishwanath.bs@ti.com,
linux-omap@vger.kernel.org, b-cousson@ti.com, rnayak@ti.com
Subject: Re: [RFC PATCH 4/6] OMAP4: Temperature sensor device support
Date: Wed, 10 Aug 2011 05:41:02 -0700 [thread overview]
Message-ID: <20110810124102.GM1939@atomide.com> (raw)
In-Reply-To: <20110810123647.GF12882@legolas.emea.dhcp.ti.com>
* Felipe Balbi <balbi@ti.com> [110810 05:31]:
>
> On Wed, Aug 10, 2011 at 05:55:20PM +0530, Keerthy wrote:
> > +
> > +int __init omap_devinit_temp_sensor(void)
> > +{
> > + if (!cpu_is_omap446x())
> > + return 0;
> > +
> > + return omap_hwmod_for_each_by_class("temperature_sensor",
> > + temp_sensor_dev_init, NULL);
> > +}
> > +
> > +arch_initcall(omap_devinit_temp_sensor);
>
> I really dislike people adding more and more *initcall() to their pieces
> of code. But Tony is the final Judge.
Yes how about making this just a regular device driver and have it
live under drivers/ somewhere?
Or is there some reason why this could not be a loadable module?
Regards,
Tony
next prev parent reply other threads:[~2011-08-10 12:41 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 12:25 [RFC PATCH 0/6] OMAP4: Temperature sensor driver Keerthy
2011-08-10 12:25 ` [RFC PATCH 1/6] OMAP4: Clock: Associate clocks for OMAP temperature sensor Keerthy
2011-08-10 12:25 ` [RFC PATCH 2/6] OMAP4: Adding the temperature sensor register set bit fields Keerthy
2011-08-10 12:25 ` [RFC PATCH 3/6] OMAP4: Hwmod: OMAP temperature sensor Keerthy
2011-08-10 12:25 ` [RFC PATCH 4/6] OMAP4: Temperature sensor device support Keerthy
2011-08-10 12:36 ` Felipe Balbi
2011-08-10 12:41 ` Tony Lindgren [this message]
2011-08-10 12:48 ` Felipe Balbi
2011-08-10 14:17 ` Cousson, Benoit
2011-08-10 21:37 ` Felipe Balbi
2011-08-11 2:40 ` J, KEERTHY
2011-08-11 10:30 ` Felipe Balbi
2011-08-11 11:01 ` J, KEERTHY
2011-08-11 14:05 ` Felipe Balbi
2011-08-11 14:15 ` J, KEERTHY
2011-08-10 12:25 ` [RFC PATCH 5/6] OMAP4460: Temperature sensor data Keerthy
2011-08-10 12:37 ` Felipe Balbi
2011-08-10 15:08 ` J, KEERTHY
2011-08-10 12:25 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Keerthy
2011-08-10 12:46 ` Felipe Balbi
2011-08-11 9:57 ` J, KEERTHY
2011-08-11 10:36 ` Felipe Balbi
2011-08-11 13:00 ` J, KEERTHY
2011-08-11 14:12 ` Felipe Balbi
2011-08-11 14:25 ` Rajendra Nayak
2011-08-11 14:32 ` J, KEERTHY
2011-08-11 18:54 ` Felipe Balbi
2011-08-11 18:55 ` Felipe Balbi
2011-08-11 21:37 ` Roger Quadros
2011-08-12 1:02 ` J, KEERTHY
2011-08-12 3:26 ` Rajendra Nayak
2011-08-12 8:44 ` Felipe Balbi
2011-08-22 23:58 ` Kevin Hilman
2011-08-23 4:18 ` Rajendra Nayak
2011-08-23 6:42 ` J, KEERTHY
2011-08-23 17:15 ` Kevin Hilman
2011-08-24 4:07 ` Rajendra Nayak
2011-08-11 16:38 ` Guenter Roeck
2011-08-10 16:35 ` [lm-sensors] " R, Durgadoss
2011-08-15 6:22 ` J, KEERTHY
2011-08-17 10:37 ` J, KEERTHY
2011-08-17 13:45 ` Guenter Roeck
2011-08-17 15:03 ` [lm-sensors] " J, KEERTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810124102.GM1939@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rnayak@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox