Re: [PATCH 06/13] ARM: gpio: davinci: convert drivers to use asm/gpio.h rather than mach/gpio.h

Russell King - ARM Linux
2011-08-09T19:45:53Z

On Tue, Aug 09, 2011 at 04:06:14PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 09-08-2011 12:06, Russell King - ARM Linux wrote:
>
> CCing linux-usb and Felipe...
>
>> Signed-off-by: Russell King<rmk+kernel@arm.linux.org.uk>
>> ---
>> drivers/usb/musb/davinci.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>> diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/davinci.c
>> index 8bdf25a..f9a3f62 100644
>> --- a/drivers/usb/musb/davinci.c
>> +++ b/drivers/usb/musb/davinci.c
>> @@ -35,7 +35,7 @@
>>
>> #include<mach/hardware.h>
>> #include<mach/memory.h>
>> -#include<mach/gpio.h>
>> +#include<asm/gpio.h>
>
> Shouldn't this now be moved to the below #include group?

When doing this kind of work with sed -i, that doesn't happen. There's
too much of this crap (and I've been telling people about this for at
least a year) that I don't think there's that luxury anymore.

If maintainers would have paid more attention, then most of these changes
would not be necessary. My view is that if maintainers do care about this
stuff _they_ should have been the ones to pick up on it long ago. In
other words, they've lost the right to complain about petty crap like
the ordering of includes through their own inaction on this point.