From: Felipe Balbi <balbi@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Dan Carpenter <error27@gmail.com>, Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
"open list:DESIGNWARE USB3 D..." <linux-usb@vger.kernel.org>,
"open list:DESIGNWARE USB3 D..." <linux-omap@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] dwc3: add a kfree() on error to dwc3_testmode_open()
Date: Fri, 26 Aug 2011 13:48:59 +0300 [thread overview]
Message-ID: <20110826104858.GG22532@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20110826103240.GA6060@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
Hi,
On Fri, Aug 26, 2011 at 12:32:40PM +0200, Sebastian Andrzej Siewior wrote:
> * Dan Carpenter | 2011-08-26 12:21:13 [+0300]:
>
> >Btw. This function returns -EBUSY on success. Was that really what
> >you want?
>
> At that time yes. The idea was to enable the self-test mode of the core
> and let it do transfers forth and back and see if it works. There is
> also no off switch. I wasn't aware that this piece of code is going to
> merged but now I think we need an off switch.
yeah, this is rather useful to test the underlying HW. We had the same
feature on MUSB and it helped check if EP0 handling and FIFO access was
working fine.
> Thanks for spotting this.
indeed.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2011-08-26 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 9:21 [patch] dwc3: add a kfree() on error to dwc3_testmode_open() Dan Carpenter
[not found] ` <20110826092113.GO5975-z0WHZYlhLlzP0Z7Jsv878P8+0UxHXcjY@public.gmane.org>
2011-08-26 9:43 ` Felipe Balbi
2011-08-26 10:32 ` Sebastian Andrzej Siewior
2011-08-26 10:48 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826104858.GG22532@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=error27@gmail.com \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox