Re: [PATCH 6/6] usb: musb: Add support for ti81xx platform

[Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

Hi,

On Fri, Aug 26, 2011 at 04:41:48PM +0530, Ajay Kumar Gupta wrote:
> @@ -57,6 +58,10 @@ config USB_MUSB_AM35X
>  	tristate "AM35x"
>  	depends on ARCH_OMAP
>  
> +config USB_MUSB_TI81XX
> +	bool "TI81XX"
> +	depends on SOC_OMAPTI81XX

this *must* be tristate. I can't emphasize enough how important this is.

> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 20a2873..07f3faf 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1014,7 +1014,9 @@ static void musb_shutdown(struct platform_device *pdev)
>  	|| defined(CONFIG_USB_MUSB_OMAP2PLUS)		\
>  	|| defined(CONFIG_USB_MUSB_OMAP2PLUS_MODULE)	\
>  	|| defined(CONFIG_USB_MUSB_AM35X)		\
> -	|| defined(CONFIG_USB_MUSB_AM35X_MODULE)
> +	|| defined(CONFIG_USB_MUSB_AM35X_MODULE)	\
> +	|| defined(CONFIG_USB_MUSB_TI81XX)		\
> +	|| defined(CONFIG_USB_MUSB_TI81XX_MODULE)

we really need to find a better way to handle this :-(

> diff --git a/drivers/usb/musb/ti81xx.c b/drivers/usb/musb/ti81xx.c
> new file mode 100644
> index 0000000..f95774e
> --- /dev/null
> +++ b/drivers/usb/musb/ti81xx.c

I still think this should be part of am35x.c It really look like they
are very similar.

on monday I'll read the rest of the file.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]