Re: [RFC PATCH v2 0/6] TI81XX: Add clock and hwmod data

Paul Walmsley
2011-10-04T09:24:13Z

Hi,

On Tue, 23 Aug 2011, Hemant Pedanekar wrote:

> This patch set is the v2 of TI816X clock and hwmods patches sent earlier.
>
> The clock data is currently added only for TI816X, while minimal hwmod data
> common for TI816X and TI814X is added.
>
> This patch set depends on following patches:
> TI81XX: Prepare for addition of TI814X support
> TI814X: Add cpu type macros and detection support
> TI814X: Create board support and enable build for TI8148 EVM
>
> Please note that CHIP_IS_TI816X/CHIP_IS_TI814X are still being used and I will
> send update once SoC list usage is available.

I've been spending some time with these patches. A few aspects don't make
much sense to me. For example, looking at the TRMs, the 816x doesn't seem
to have powerdomains for HDVICP0, 1, or 2, although they are listed in the
patch. Also, the clockdomain layout is quite different between 814x and
816x, according to the TRMs. Are the patches more accurate than the TRMs,
or vice versa?

Will send over the current reworked patches for TI81XX PRCM accessors,
powerdomain code & data, and clockdomain code & data. They are intended
to apply over the TI814x patches that you sent recently. I'd like to get
your opinion(s) on these reworked patches. Please note, so far they have
only been compile-tested.

- Paul