Re: [PATCH] OMAP4: MMC: fix power and audio issue, decouple USBC1 from MMC1

T Krishnamoorthy, Balaji
2011-09-28T12:34:44Z

Hi Tony,

Can you queue this patch ?

On Fri, Sep 9, 2011 at 7:34 PM, T Krishnamoorthy, Balaji
<balajitk@ti.com> wrote:
> On Fri, Aug 12, 2011 at 8:43 PM, Buckley, Bryan <bryan.buckley@ti.com> wrote:
>> On Fri, Jul 22, 2011 at 7:30 AM, Kishore Kadiyala
>> <kishorek.kadiyala@gmail.com> wrote:
>>>
>>> On Fri, Jul 22, 2011 at 12:59 AM, Bryan Buckley <bryan.buckley@ti.com> wrote:
>>> > Remove OMAP4_USBC1_ICUSB_PWRDNZ_MASK during enable/disable PWRDNZ mode for
>>> > MMC1_PBIAS and associated extended-drain MMC1 I/O cell. This is in accordance
>>> > with the control module programming guide. This fixes a bug where if trying to
>>> > use gpio_98 or gpio_99 and MMC1 at the same time the GPIO signal will be
>>> > affected by a changing SDMMC1_VDDS.
>>> >
>>> > Software must keep MMC1_PBIAS cell and MMC1_IO cell PWRDNZ signals low whenever
>>> > SDMMC1_VDDS ramps up/down or changes for cell protection purposes.
>>> >
>>> > MMC1 is based on SDMMC1_VDDS whereas USBC1 is based on SIM_VDDS therefore
>>> > they can operate independently.
>>> >
>>> > Signed-off-by: Bryan Buckley <bryan.buckley@ti.com>
>>>
>>> Good catch,
>>>
>>> Acked-by:  Kishore Kadiyala <kishore.kadiyala@ti.com>
>>>
>>
>> Any other comments from anyone else?  Noticed that this commit isn't
>> in any upstream branches. This patch will fix issues with people who
>> want to use GPIO 98/99 AND MMC1 at the same time.  Would be good to
>> have this fix upstream.
>>
> FWIW: Tested on OMAP4 Blaze
> Tested-by: Balaji T K <balajitk@ti.com>