From: Samuel Ortiz <sameo@linux.intel.com>
To: Todd Poynor <toddpoynor@google.com>
Cc: linux-omap@vger.kernel.org, Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH 1/2] mfd: twl6030: fix lockdep recursion warning on setting wake IRQs
Date: Tue, 4 Oct 2011 11:56:53 +0200 [thread overview]
Message-ID: <20111004095653.GT4118@sortiz-mobl> (raw)
In-Reply-To: <1317080664-28096-1-git-send-email-toddpoynor@google.com>
Hi Todd,
On Mon, Sep 26, 2011 at 04:44:23PM -0700, Todd Poynor wrote:
> LOCKDEP explicitly sets all irq_desc locks as a single lock-class,
> causing "possible recursive locking detected" when the TWL RTC
> driver calls through enable_irq_wake to twl6030_irq_set_wake,
> which recursively calls irq_set_irq_wake. Although the
> irq_desc and lock are different, LOCKDEP treats these as
> equivalent, presumably due to problems that can be incurred
> when locking more than one irq_desc, so best to avoid this.
>
> Suspend/resume actions implemented as PM notifiers to avoid
> touch the TWL core for this.
Thanks for that, I applied this patch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2011-10-04 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 23:44 [PATCH 1/2] mfd: twl6030: fix lockdep recursion warning on setting wake IRQs Todd Poynor
2011-09-26 23:44 ` [PATCH 2/2] mfd: twl6030: Disable IRQ during suspend Todd Poynor
2011-09-27 5:15 ` Santosh Shilimkar
2011-10-04 9:57 ` Samuel Ortiz
2011-09-27 5:14 ` [PATCH 1/2] mfd: twl6030: fix lockdep recursion warning on setting wake IRQs Santosh Shilimkar
2011-10-04 9:56 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004095653.GT4118@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox