Re: [PATCH 1/9] regulator: twl: Remove hardcoded board constraints from driver

Mark Brown
2011-09-27T11:37:21Z

On Tue, Sep 27, 2011 at 03:42:44PM +0530, Rajendra Nayak wrote:
> Remove the hardcoded .valid_modes_mask and .valid_ops_mask for
> each regulator from the twl driver and let the boards pass it.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>

> - /* Constrain board-specific capabilities according to what
> - * this driver and the chip itself can actually do.
> - */
> - c = &initdata->constraints;
> - c->valid_modes_mask &= REGULATOR_MODE_NORMAL | REGULATOR_MODE_STANDBY;
> - c->valid_ops_mask &= REGULATOR_CHANGE_VOLTAGE
> - | REGULATOR_CHANGE_MODE
> - | REGULATOR_CHANGE_STATUS;

This isn't actually hard coding constraints, this is restricting the
constraints passed in further rather than adding new ones.

However should be fine:

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>