public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Steve Sakoman <sakoman@gmail.com>
Cc: Dave Hylands <dhylands@gmail.com>, linux-omap@vger.kernel.org
Subject: Re: Regressions for older OMAP3503 silicon
Date: Wed, 5 Oct 2011 11:59:16 -0700	[thread overview]
Message-ID: <20111005185916.GB6324@atomide.com> (raw)
In-Reply-To: <CAGDS+nkHCmt0+Z82fSX3+bRLy4RR-_4vegb0tGUwD5u_ttnMSw@mail.gmail.com>

* Steve Sakoman <sakoman@gmail.com> [111005 10:46]:
> On Wed, Oct 5, 2011 at 9:26 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Dave Hylands <dhylands@gmail.com> [111004 23:41]:
> 
> >> I then also had to modify drivers/mmc/card/block.c and initializing
> >> disable_multi to 1 in the mmc_blk_issue_rw_rq function to get rid of
> >> the following messages for every I/O request.
> >>
> >> mmcblk0: retrying using single block read
> >> mmcblk0: retrying using single block read
> >> mmcblk0: retrying using single block read
> >> mmcblk0: retrying using single block read
> >>
> >> (since this revision of the silicon doesn't support multi-block MMC reads).
> >
> > ..but this one is usually a problem muxing the MMC data lines.
> >
> > Are you sure this revision only supports one data line?
> 
> No, I think you misunderstood the issue!
> 
> The issue is that multi-block mmc reads are broken and the code falls
> back to single block reads but prints a warning each time.
> 
> Looking for a definitive source for this errata with Google I find:
> 
> "According to the TI docs, multiple block read transfer
> does not work correctly in CPU revisions 2.1 and earlier (TI advisory
> 2.1.1.128)."

OK, thanks for correcting me.
 
> So the correct fix is probably to use multi-block reads only on
> revisions post 2.1.

Or just permanently switch to single-block reads if the multi-block
reads fail?

Regards,

Tony

  reply	other threads:[~2011-10-05 18:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05  7:14 Regressions for older OMAP3503 silicon Dave Hylands
2011-10-05 16:26 ` Tony Lindgren
2011-10-05 18:01   ` Paul Walmsley
2011-10-05 18:19   ` Steve Sakoman
2011-10-05 18:59     ` Tony Lindgren [this message]
2011-10-06  6:29     ` Dave Hylands
2011-10-05 18:09 ` Paul Walmsley
2011-10-06  6:24   ` Dave Hylands
2011-10-06 16:14     ` Paul Walmsley
2011-10-06 14:23   ` Steve Sakoman
2011-10-05 18:10 ` Kevin Hilman
2011-10-05 18:35   ` Paul Walmsley
2011-10-05 19:48   ` Steve Sakoman
2011-10-05 21:20     ` Paul Walmsley
2011-10-05 23:28     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111005185916.GB6324@atomide.com \
    --to=tony@atomide.com \
    --cc=dhylands@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox