From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@ti.com>
Cc: "Premi, Sanjeev" <premi@ti.com>,
"Hiremath, Vaibhav" <hvaibhav@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"paul@pwsan.com" <paul@pwsan.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Mohammed, Afzal" <afzal@ti.com>
Subject: Re: [PATCH-V3 2/4] arm:omap:am33xx: Update common OMAP machine specific sources
Date: Thu, 6 Oct 2011 16:03:08 -0700 [thread overview]
Message-ID: <20111006230308.GX6324@atomide.com> (raw)
In-Reply-To: <87ehyyj6ts.fsf@ti.com>
* Kevin Hilman <khilman@ti.com> [110930 09:35]:
> "Premi, Sanjeev" <premi@ti.com> writes:
>
> Actually, looking at this closer, I think the infrastructure is already
> there to handle this cleanly.
>
> Basically, dpll5 should not even be registered for SoCs where it doesn't
> exist. Then, any attempts to use DPLL5 would know it doesn't exist
> because the call to clk_get() in omap3_clk_lock_dpll5() would fail.
Yes please use the SoC specific lists, see what we have now queued
up in sram-map-io branch. So using SoC specific map_io + init_early +
set_globals should do the trick.
> I think the clock3xxx_data.c needs a bit more cleanup so that only
> clocks that exist for a given SoC are registered.
>
> Paul already did a similar cleanup for the powerdomain data files by
> creating separate lists for common ones and unique ones. Looks like we
> need the same for the clock data.
Right.
Regards,
Tony
next prev parent reply other threads:[~2011-10-06 23:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 14:32 [PATCH-V3 2/4] arm:omap:am33xx: Update common OMAP machine specific sources hvaibhav
2011-09-26 18:45 ` Kevin Hilman
2011-09-30 12:09 ` Premi, Sanjeev
2011-09-30 17:09 ` Kevin Hilman
2011-10-06 23:03 ` Tony Lindgren [this message]
2011-11-03 13:48 ` Hiremath, Vaibhav
2011-11-05 9:41 ` Hiremath, Vaibhav
2011-11-05 10:29 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006230308.GX6324@atomide.com \
--to=tony@atomide.com \
--cc=afzal@ti.com \
--cc=hvaibhav@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox