From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2] ARM: OMAP3: hwmod: fix variant registration and remove SmartReflex from common list Date: Thu, 6 Oct 2011 16:29:00 -0700 Message-ID: <20111006232900.GC6324@atomide.com> References: <20111006223545.GB27281@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:50712 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998Ab1JFX3E (ORCPT ); Thu, 6 Oct 2011 19:29:04 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: Russell King - ARM Linux , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Abhilash K V , Chase Maupin * Paul Walmsley [111006 15:50]: > > Commit d6504acd2125984c61dce24727dd3842d0144015 ("OMAP2+: hwmod: > remove OMAP_CHIP*") tests the inverse condition of what it should be > testing for the return value from omap_hwmod_register(). This causes > several IP blocks to not be registered on several OMAP3 family devices. > > Fixing that bug also unmasked another bug, originally reported by > Chase Maupin and then subsequently by Abhilash K > V , which caused SmartReflex IP blocks to be > registered on SoCs that don't support them. > > Thanks to Russell King - ARM Linux for comments > on a previous version of the patch. > > Signed-off-by: Paul Walmsley > Cc: Chase Maupin > Cc: Abhilash K V > Cc: Russell King - ARM Linux > --- > > This version incorporates some comments from RMK. Thanks, updating in fixes-part2. Tony