From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 1/5] drivercore: add new error value for deferred probe Date: Thu, 6 Oct 2011 23:43:49 -0700 Message-ID: <20111007064349.GD27508@kroah.com> References: <1317963790-29426-1-git-send-email-manjugk@ti.com> <1317963790-29426-2-git-send-email-manjugk@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1317963790-29426-2-git-send-email-manjugk@ti.com> Sender: linux-mmc-owner@vger.kernel.org To: "G, Manjunath Kondaiah" Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Grant Likely , Dilan Lee , Mark Brown , Manjunath GKondaiah , Arnd Bergmann List-Id: linux-omap@vger.kernel.org On Fri, Oct 07, 2011 at 10:33:06AM +0500, G, Manjunath Kondaiah wrote: > > Add new error value so that drivers can request deferred probe > from drivercore. > > Signed-off-by: G, Manjunath Kondaiah > Reported-by: Grant Likely > --- > Cc: linux-omap@vger.kernel.org > Cc: linux-mmc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Grant Likely > Cc: Greg Kroah-Hartman > Cc: Dilan Lee > Cc: Mark Brown > Cc: Manjunath GKondaiah > Cc: Arnd Bergmann > > include/linux/errno.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/linux/errno.h b/include/linux/errno.h > index 4668583..83d8fcf 100644 > --- a/include/linux/errno.h > +++ b/include/linux/errno.h > @@ -16,6 +16,7 @@ > #define ERESTARTNOHAND 514 /* restart if no handler.. */ > #define ENOIOCTLCMD 515 /* No ioctl command */ > #define ERESTART_RESTARTBLOCK 516 /* restart by calling sys_restart_syscall */ > +#define EPROBE_DEFER 517 /* restart probe again after some time */ Can we really do this? Isn't this some user/kernel api here? What's wrong with just "overloading" on top of an existing error code? Surely one of the other 516 types could be used here, right? greg k-h